-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change accepted syntax for code fence #690
Change accepted syntax for code fence #690
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, this looks good and makes sense as a simplification. Do you mind sharing the discussion (was it an issue? Slack?) that led to this just so I can read that before merging? Thank you!
The link to a slack thread is in the PR description, let me know if you have access to it 😄 |
So I think that link goes to the SWM slack and I can't access. Basically I just wanted to make sure this was run by someone on the Expensify side before I merged? Since it's (sort of) a product decision. I think this makes the most sense to me but wanted to make sure I was the second opinion haha. Thank you! |
Hi, sorry - I was on sick leave last week 😅 I've sent you screenshots of our discussion with Expensify on Slack in a DM 🙌🏻 |
Thank you! That was helpful - merging now. |
(and glad you're feeling better!) |
} | ||
return `${g1}<code>${g2}</code>${g3}`; | ||
}, | ||
regex: /(\B|_|)`(.*?(?![`])\S.*?)`(\B|_|)(?!`|[^<]*<\/pre>)/gm, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change might've caused the following issue:
We're currently working on adding styles to
code fence
&inline code
blocks to Live Markdown. After some discussion regardingcode fence
/pre
block we agreed that the best way to handle it is to limit the accepted syntax variations.This PR adds these changes directly to ExpensiMark 🙌🏻
Fixed Issues
$ GH_LINK
Tests
All of the tests that have changed in this PR
I tested it both in Live Markdown & in the Expensify App to make sure that it didn't break anything
QA
Check if there's just one syntax valid for
pre
blocks which should be:Mainly Expensify chat & how it treats messages sent with different syntax variations. Live Markdown will include these changes after we get this PR merged 👀
Screen.Recording.2024-05-14.at.14.18.30.mov