Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating web-e dependence on sequence numbers #570

Merged
merged 11 commits into from
Oct 25, 2023

Conversation

chiragsalian
Copy link
Contributor

@chiragsalian chiragsalian commented Sep 1, 2023

Fixed Issues

Helps with https://github.com/Expensify/Expensify/issues/312870

Tests

Covered in https://github.com/Expensify/Web-Expensify/pull/38752

QA

None. Regression testing should capture any issues.

@chiragsalian chiragsalian self-assigned this Sep 1, 2023
@chiragsalian chiragsalian changed the title Deprecating Report_GetHistory using offset Deprecating web-e dependence on sequence numbers Oct 23, 2023
@chiragsalian chiragsalian marked this pull request as ready for review October 24, 2023 00:01
@chiragsalian chiragsalian requested a review from a team as a code owner October 24, 2023 00:01
@melvin-bot melvin-bot bot requested review from rlinoz and removed request for a team October 24, 2023 00:01
lib/ReportHistoryStore.jsx Outdated Show resolved Hide resolved
lib/ReportHistoryStore.jsx Outdated Show resolved Hide resolved
lib/ReportHistoryStore.jsx Show resolved Hide resolved
@chiragsalian chiragsalian changed the title Deprecating web-e dependence on sequence numbers [WIP] Deprecating web-e dependence on sequence numbers Oct 24, 2023
@chiragsalian chiragsalian changed the title [WIP] Deprecating web-e dependence on sequence numbers Deprecating web-e dependence on sequence numbers Oct 24, 2023
@chiragsalian
Copy link
Contributor Author

Updated and ready for review

@rlinoz rlinoz merged commit e35083e into main Oct 25, 2023
5 checks passed
@rlinoz rlinoz deleted the chirag-deprecating-sequenceNumber branch October 25, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants