[HOLD] Add bulk actions #51913

luacmartins · 2024-11-01T21:48:57Z

Explanation of Change

This PR adds the ability to bulk approve and pay expenses/reports on the search page.

Fixed Issues

$ #51911

Tests

Pre-requisites:

2 reports that can be approved with a single expense
2 reports that can be approved with multiple expenses
1 report that cannot be approved

Tests steps:

Navigate to the Search page, Expenses > All
Verify that you see the Approve button next to the 2 expenses that can be approved
Select both expenses that can be approved and 1 expense that cannot be approved
Press the 3 selected dropdown at the header
Verify that you do not see the Approve option
Deselect the report that cannot be approved (so you only have both reports that can be approved selected)
Verify that you do see the Approve option in the header 2 selected dropdown button
Select the approve option from the dropdown
Verify that the reports are approved
Repeat steps 1-9 for the Expenses > Outstanding page with the reports with multiple expenses

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Screen.Recording.2024-11-06.at.1.27.59.PM.mov

Screen.Recording.2024-11-06.at.1.30.48.PM.mov

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-11-05T23:37:18Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins · 2024-11-05T23:38:09Z

@Pujan92 this PR is on hold. Please wait to review until I remove the hold.

Pujan92 · 2024-11-11T17:41:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-11-12.at.19.49.46.mov

Screen.Recording.2024-11-12.at.19.54.06.mov

MacOS: Desktop

luacmartins · 2024-11-11T17:43:32Z

@Pujan92 please hold on reviewing for a moment. I've seen some weird behavion in my latest tests and I'd like to take a look first

Pujan92 · 2024-11-11T17:44:30Z

Ok @luacmartins

luacmartins · 2024-11-11T18:15:17Z

@Pujan92 issue is fixed. Please continue with review

github-actions · 2024-11-11T18:49:24Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/51913/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/51913/NewExpensify.dmg	https://51913.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

Pujan92 · 2024-11-12T14:30:58Z

Only for the first time, I see partial transactions approved. Not able to reproduce after that so I don't have the logs. I will try diff scenarios to catch it again otherwise LGTM!

Screen.Recording.2024-11-12.at.19.46.38.mov

Pujan92

LGTM!

melvin-bot · 2024-11-12T14:32:40Z

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

deetergp

LGTM2 👍

luacmartins · 2024-11-12T22:48:37Z

I'm putting a hold on this since the underlying PR this depends on is being reverted

add approve and pay bulk actions

059316a

luacmartins self-assigned this Nov 1, 2024

luacmartins added 12 commits November 1, 2024 15:57

add data to selected transactions;

087a4d3

get reportIDs

45e3944

Merge branch 'main' into cmartins-addBulkActions

5685f78

fix logic to show button

533f91e

handle bulk pay

42f5310

fix lint

543d748

fix ts

6970f3e

update dependency array

700bfc8

update param name

166923b

Merge branch 'cmartins-showButtons' into cmartins-addBulkActions

46b7cd3

fix ts

8277ee5

update docs

0d3a83f

luacmartins changed the title ~~Add bulk actions~~ [HOLD App 51445] Add bulk actions Nov 5, 2024

luacmartins marked this pull request as ready for review November 5, 2024 23:37

luacmartins requested a review from a team as a code owner November 5, 2024 23:37

melvin-bot bot requested review from Pujan92 and removed request for a team November 5, 2024 23:37

luacmartins mentioned this pull request Nov 6, 2024

[Search v1] Add bulk actions on Search #51911

Open

luacmartins requested a review from dubielzyk-expensify November 6, 2024 15:52

luacmartins added the Ready To Build label Nov 6, 2024

This comment has been minimized.

Sign in to view

luacmartins added 3 commits November 6, 2024 13:13

resolve conflicts

a72db91

resolve conflits

9dcc965

Merge branch 'main' into cmartins-addBulkActions

25672e4

luacmartins changed the title ~~[HOLD App 51445] Add bulk actions~~ Add bulk actions Nov 11, 2024

fix loading state

5929160

Pujan92 approved these changes Nov 12, 2024

View reviewed changes

melvin-bot bot requested a review from deetergp November 12, 2024 14:32

deetergp approved these changes Nov 12, 2024

View reviewed changes

luacmartins changed the title ~~Add bulk actions~~ [HOLD] Add bulk actions Nov 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD] Add bulk actions #51913

[HOLD] Add bulk actions #51913

luacmartins commented Nov 1, 2024 •

edited

Loading

melvin-bot bot commented Nov 5, 2024

luacmartins commented Nov 5, 2024

This comment has been minimized.

Pujan92 commented Nov 11, 2024 •

edited

Loading

luacmartins commented Nov 11, 2024

Pujan92 commented Nov 11, 2024

luacmartins commented Nov 11, 2024

github-actions bot commented Nov 11, 2024

Pujan92 commented Nov 12, 2024 •

edited

Loading

Pujan92 left a comment

melvin-bot bot commented Nov 12, 2024

deetergp left a comment

luacmartins commented Nov 12, 2024 •

edited

Loading

[HOLD] Add bulk actions #51913

Are you sure you want to change the base?

[HOLD] Add bulk actions #51913

Conversation

luacmartins commented Nov 1, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 5, 2024

luacmartins commented Nov 5, 2024

This comment has been minimized.

Pujan92 commented Nov 11, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

luacmartins commented Nov 11, 2024

Pujan92 commented Nov 11, 2024

luacmartins commented Nov 11, 2024

github-actions bot commented Nov 11, 2024

Pujan92 commented Nov 12, 2024 • edited Loading

Pujan92 left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Nov 12, 2024

deetergp left a comment

Choose a reason for hiding this comment

luacmartins commented Nov 12, 2024 • edited Loading

luacmartins commented Nov 1, 2024 •

edited

Loading

Pujan92 commented Nov 11, 2024 •

edited

Loading

Pujan92 commented Nov 12, 2024 •

edited

Loading

luacmartins commented Nov 12, 2024 •

edited

Loading