Bump react-native-live-markdown to newest version and remove/rename patches

[MrRefactor]

Details

Bumping react-native-live-markdown to newest version in order to remove patches for react-native 0.75 support.

Fixed Issues

$ #37374
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

• Red spell check line is shown frequently in composer when typing in version 0.1.133 - PR
  Test steps:

1. Open any chat
2. Start typing any sentence
3. Verify if the red spell check line isn't shown while still typing a word
4. Verify if the red spell check line is being added correctly

• Voice recognition doesn't work on mobile web on Android in the message compose input in version 0.1.130 - PR
  Test steps:

1. Open any chat
2. Start inserting text using voice recognition
3. Verify the input content. Check if it wasn't doubled and if it's correct

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[tomekzaw]

The PR looks good. Can we also remove @expensify+react-native-live-markdown+0.1.129+001+hybrid-app.patch? I believe this change has not been upstreamed to react-native-live-markdown yet.

[Skalakid]

@MrRefactor Hi, I see that you will be bumping the react-native-live-markdown version to 0.1.135 after merging this PR in the library. This will be a bigger version jump and contain my fixes for 2 issues in E/App. Can we please add QA steps to this PR so my bug fixes will also be tested?

Here are the issues that I fixed and your bump will contain them:

• Red spell check line is shown frequently in composer when typing in version 0.1.133 - PR
  Test steps:

1. Open any chat
2. Start typing any sentence
3. Verify if the red spell check line isn't shown while still typing a word
4. Verify if the red spell check line is being added correctly

• Voice recognition doesn't work on mobile web on Android in the message compose input in version 0.1.130 - PR
  Test steps:

1. Open any chat
2. Start inserting text using voice recognition
3. Verify the input content. Check if it wasn't doubled and if it's correct

[MrRefactor]

@Skalakid sure thing, updated

[MrRefactor]

@shubham1206agra hey, PR is ready to be reviewed.
cc: @Skalakid

[VickyStash]

@MrRefactor could you please update the lib to the latest version, so these fixes are included 🙏
cc @parasharrajat

[MrRefactor]

@VickyStash done

[MrRefactor]

@mountiny can we go ahead with that PR?

[tomekzaw]

Thanks for bumping!

[mountiny]

@VickyStash @MrRefactor We should test the fixes from the library are working in the App on this PR, were all of them tested across platforms?

[mountiny]

Started a thread here to talk about this one

[ZhenjaHorbach]

Actually we have conflicts in this PR

[ZhenjaHorbach]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

All platforms

https://drive.google.com/drive/folders/1uqNpJvfX_D9H64pWT8yKb3k62lZzFCdF?usp=drive_link

[MrRefactor]

@ZhenjaHorbach resolved conflicts

[ZhenjaHorbach]

I have some updates
And I'm almost done testing

@mountiny
But I need Adhoc build for testing one bug
Could you help with this please?

And we have 2 categories of updates

Bug fixes

121 - Fix deleting whole content on Firefox (#463) Pass
130 - Fix voice recognition on mWeb (#468) Pass
139 - Fix single line input (#482) Pass
140 - Fix removeSpan crash on Android (#469) Pass
142 - Fix height update delay on iOS on RN 0.75 with new arch enabled (#474) Pass but notice a bit strange behavior Pass

@tomekzaw
Could you check please ?

On Android
The height changes in 2 stages
As a result
For a short period of time first line is cut off

142-android.mov

143 - Update emoji font size if it was updated in markdownStyle (#475) Pass

Various updates (When testing bug fixes, I do regression testing for text inputs in general )

122 - Support React Native 0.74 (#358)
123 - Don't use ShadowNodeFragment::Value (#426)
124 - Rename type Range to MarkdownRange (#464)
125 - feat: add load method (#460)
126 - Move MarkdownType and MarkdownRange to commonTypes.ts (#466)
127 - Enable new arch by default in example app (#465)
128 - Expose React Native minor version in buildscripts (#467)
129 - feat: add support for RN 0.75 (#428)
131 - Add visionOS support (#194)
132 - Use node resolver to locate React Native package (#472)
133 - Fix red spell check line is shown frequently when typing (#470)
134 - Bump expensify-common version to latest version (#477)
135 - Add hybrid app support (#476)
136 - Disable building example app from source on Android (#478)
137 - Add missing C++ namespaces (#480)
138 - Add missing NS_ASSUME_NONNULL macro (#479)
141 - Support React Native 0.76 (#483)

[tomekzaw]

@ZhenjaHorbach Thanks for reviewing

On Android
The height changes in 2 stages
As a result
For a short period of time first line is cut off

This is unfortunately an issue in React Native (all TextInput components suffer from this very problem). Since MarkdownTextInput extends TextInput, the behavior is propagated. The root cause of this problem is that the content of the text input is updated on the UI thread but the height of the component (and the layout of the rest of the components) needs to be calculated by Yoga and mounted separately after a commit on the JS thread. So this needs to be addressed separately. You can verify that by replacing MarkdownTextInput with TextInput and trying to reproduce the problem simply by appending a newline.

Also, this behavior on Android has nothing to do with Expensify/react-native-live-markdown#474 since this PR contains only iOS changes.

[ZhenjaHorbach]

@ZhenjaHorbach Thanks for reviewing

On Android
The height changes in 2 stages
As a result
For a short period of time first line is cut off

This is unfortunately an issue in React Native (all TextInput components suffer from this very problem). Since MarkdownTextInput extends TextInput, the behavior is propagated. The root cause of this problem is that the content of the text input is updated on the UI thread but the height of the component (and the layout of the rest of the components) needs to be calculated by Yoga and mounted separately after a commit on the JS thread. So this needs to be addressed separately. You can verify that by replacing MarkdownTextInput with TextInput and trying to reproduce the problem simply by appending a newline.

Also, this behavior on Android has nothing to do with Expensify/react-native-live-markdown#474 since this PR contains only iOS changes.

Oh sorry
I didn't notice that there were changes only in ios folder 😅

[tomekzaw]

@ZhenjaHorbach No worries! I'm glad you found the height jump issue on Android – I wish we could address that in the future as well.

[ZhenjaHorbach]

Found this
Need to check on the latest version of main
But when we open the chat and add emoji
The emoji tries to fly away 😅

143-BUG.mov

[ZhenjaHorbach]

Video from main
Slightly different behavior

2024-09-13.15.53.20.mov

[MrRefactor]

@VickyStash could you look at that emoji behaviour?

[VickyStash]

@VickyStash could you look at that emoji behaviour?

It's hard for me to say right away what's wrong here and I'm not sure I'll have enough time today to dig more into it. (I'll be OOO next week). Though I think the current version looks better than jumping/emojis cutting off on the main.
cc @tomekzaw

[tomekzaw]

@ZhenjaHorbach Thanks for finding the regression with emoji in #48626 (comment). This indeed looks like an incorrect behavior.

I'd like to suggest merging this PR as it is now (since it fixes 5+ issues) and reporting this behavior as a separate issue so it can be fixed incrementally.

[ZhenjaHorbach]

@ZhenjaHorbach Thanks for finding the regression with emoji in #48626 (comment). This indeed looks like an incorrect behavior.

I'd like to suggest merging this PR as it is now (since it fixes 5+ issues) and reporting this behavior as a separate issue so it can be fixed incrementally.

I don't mind !
Only thing I didn't tested this fix bug
130 - Fix voice recognition on mWeb (#468) Need ad-hoc build

The changes were only in the web 😅
So I was able to test !

[ZhenjaHorbach]

LGTM !

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[mountiny]

Thanks for thorough testing @ZhenjaHorbach

[OSBotify]

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.0.35-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/grgia in version: 9.0.35-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅