Enlarge emojis in other contexts than just single character messages

[VickyStash]

Details

This is another try to merge the PR related to emojis enlarging, the previous one was reverted.

Fixed Issues

$ #4114
PROPOSAL: N/A

Tests

• Verify that no errors appear in the JS console

Composer:

1. Draft a message (of any length) with text and emojis
2. Verify that emojis are larger (17px) compared to the default size for text (15px) in the composer (emojis + text input)

Report history:

1. Send a message with emojis and text
2. Verify that emojis are larger (17px) compared to the default size for text (15pt) in the chat history and vertically centered with respect to eachother, such that the baseline of the emoji is below the plain text and the middle of the text vertically aligns with the middle of the emoji [$1000] Make emojis larger in other contexts than just single character messages #4114 (comment)

Settings:

1. Go to Settings -> Profile and add emoji to your last name
2. Verify that emoji appear larger (17px) than the rest of the text (15pt) in the text input
3. Save the changes
4. Open LHP
5. Verify that emoji in user's last name appear larger (25px) compared to the rest of the text (22px)

Offline tests

Same as in the Tests section.

QA Steps

• Verify that no errors appear in the JS console

Same as in the Tests section.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

[melvin-bot]

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[shawnborton]

I can try to add a 1-2px space between name and message in case both of them have emojis.

Personally I think we should avoid that. I don't think we should be making too many conditional spacing adjustments in the UI if we can avoid it. cc @Expensify/design for thoughts too.

[dannymcclain]

Personally I think we should avoid that. I don't think we should be making too many conditional spacing adjustments in the UI if we can avoid it.

Agree! I feel like this situation is not worth addressing. Nothing is broken, nothing looks absolutely terrible, and I personally feel like this is just one of those consequences of users doing things we have no way of predicting. If something looked really borked because of this, I'd say it's worth addressing, but it doesn't really feel that way to me. 🤷‍♂️ Just my 2 cents.

[parasharrajat]

@VickyStash Any updates. From the above comments, It seems that we can ignore that spacing issue.

[VickyStash]

@parasharrajat All other issues are related to how react-native-live-markdown works.

1. This two are related to markdownStyle updates to emoji.fontSize aren't applied right away on iOS react-native-live-markdown#448
   BUG: IOS: emoji pasted from Emoji picker is not enlarged.
   BUG: IOS: Emoji is cut from the top.
   I can try to take a look at this issue in the lib on the next week.
2. BUG: Text alignment is a little off on the text input as compared to Staging. The text is slightly lifted - It also relates to how react-native-live-markdown input renders. I can fix it on the app side by updating the paddingTop to 25 for markdown input. What do you think?

Note: I'll be OOO 5th-6th Sept

[parasharrajat]

how react-native-live-markdown input renders. I can fix it on the app side by updating the paddingTop to 25 for markdown input. What do you think?

I would prefer it to be solved on lib then. Styles hacks do not scale well across platforms.

[VickyStash]

Updates:
I've opened a Draft PR to fix ios related issues in react-native-live-markdown lib. More details can be found here.

[VickyStash]

Updates: after merging the latest main, a couple of weird issues appeared on iOS. For example: on the first report screen open the emojis in the display names and messages looks okay, but if I reopen the same screen it's overlapped. I'm working on the fixes.
As for the Draft PR from react-native-live-markdown - it fixes only one of two bugs, the emoji is increased right away, but it's still cropped, so I need to find the solution.

[parasharrajat]

Thanks for the update.

[VickyStash]

I haven't had a lot of time for this issue today, but should be more focused on it tomorrow.

after merging the latest main, a couple of weird issues appeared on iOS

I've found the reason of this issues and was able to find a fix. It was related to the ALL_EMOJIS regex const.
Continue to investigate the emojis cropping inside the composer when only emojis are entered.

[VickyStash]

@parasharrajat

BUG: IOS: emoji pasted from Emoji picker is not enlarged.
BUG: IOS: Emoji is cut from the top.

This two seems to be resolved with:

• The fix on the app side: eb3a958
• And two react-native-live-markdown PRs:
  • Emoji size update: Update emoji font size if it was updated in markdownStyle react-native-live-markdown#475 or Improve performance on iOS react-native-live-markdown#356
  • The one which fixes the height update: Fix height update delay on iOS on RN 0.75 with new arch enabled react-native-live-markdown#474

That's how it works:

fixed_ios_2_prs.mp4

[tomekzaw]

Both PRs to react-native-live-markdown have been merged:

• Fix height update delay on iOS on RN 0.75 with new arch enabled react-native-live-markdown#474
• Update emoji font size if it was updated in markdownStyle react-native-live-markdown#475

[VickyStash]

The react-native-live-markdown version will be bumped in this PR.

As for this one:

BUG: Text alignment is a little off on the text input as compared to Staging. The text is slightly lifted.

@parasharrajat @tomekzaw
As I mentioned, the styling applied to the input is the same. The only difference is the component that is used. In case of markdown input the text is splitted into span's and displayed. The reason of visual difference is that the vertical alignment of the text inside the input before and inside the span now is different.

Before (Prod)	Current version

I achieved more expected alignment by manually applying to the text spans verticalAlign: 'middle'.

Before (Prod)	Current version	With text spans verticalAlign: 'middle' applied

But it looks like to be able to handle it we need to add the support for the text data type inside markdownStyle or set the middle alignment for the text spans by default (second option is less safe).
@tomekzaw Do I miss anything? Maybe there is an easier way to handle it?

Note about what I've updated in the markdown lib to align text inside text spans

[tomekzaw]

@VickyStash Let me summon @Skalakid who's the author of web implementation of react-native-live-markdown.

@Skalakid Could you please respond to #47547 (comment)?

[Skalakid]

Hi @VickyStash, I think we can just set the middle alignment for the text spans by default in blockUtils. I'm not sure about about adding support for text data type in markdownStyles since text label is web only feature. If we decide to go with this option it would be nice to also add it to native implementation

[VickyStash]

@Skalakid It looks like setting the middle alignment by default in blockUtils affects the line spacing in a mutiline input.
Screenshots from main:

Before	After

But we can try to update MarkdownTextInput.css with:

.react-native-live-markdown-input-singleline span[data-type="text"] {
  vertical-align: middle;
}

This way it affects only singleline inputs. What do you think?

[Skalakid]

@VickyStash oh okay, I think it a good idea. Let's add the css style 😄

[VickyStash]

I've opened the PR for the web fix mentioned above: Expensify/react-native-live-markdown#486

[VickyStash]

Updates:
It looks like all of the issues reported during the review are resolved.
We are just waiting for the react-native-live-markdown version is bumbed to the version with iOS fixes. Then we need to update the version to 0.1.146 which includes the web fix.

Note: I'm going to be OOO next week (Sept 16-20) 🌴