[$250] Android - When cancelling payment, "Done" message displayed instead of "Pay" button

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.60-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Open the Expensify app.
2. Tap on the FAB and select "Submit Expense"
3. Complete the expense creation flow and send the expense to any workspace.
4. Tap on "Search" on the bottom of the screen.
5. Tap on "Pay" on the preview of the just created expense.
6. Once the payment is complete, tap on the expense to open the report.
7. Tap on the header and select "Cancel Payment"
8. Tap on the arrow on the top left corner to return to expense preview on search.
9. Verify that the "Pay" button is displayed again on expense preview.

Expected Result:

"Pay" button should appear again on the expense preview on search, after the payment is cancelled

Actual Result:

After cancelling expense payment, a "Done" message can be seen on the expense preview instead of the "Pay" button. The user has to leave search section and return to see the "Pay" button again

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6662571_1731420990421.Done.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021856449395622318059
• Upwork Job ID: 1856449395622318059
• Last Price Increase: 2024-11-12
• Automatic offers:
• suneox | Contributor | 104870015

Issue Owner

Current Issue Owner: @s77rt

[melvin-bot]

Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Current assignee @puneetlath is eligible for the Engineering assigner, not assigning anyone new.

[Nodebrute]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When cancelling payment, "Done" message displayed instead of "Pay" button

What is the root cause of that problem?

When we cancel payment we set CONST.REPORT.STATUS_NUM.CLOSED

App/src/libs/actions/IOU.ts

Line 7274 in 5e52372

const statusNum: ValueOf<typeof CONST.REPORT.STATUS_NUM> = approvalMode === CONST.POLICY.APPROVAL_MODE.OPTIONAL ? CONST.REPORT.STATUS_NUM.CLOSED : CONST.REPORT.STATUS_NUM.APPROVED;

so when here this isClosedReport will be true

App/src/libs/SearchUIUtils.ts

Lines 272 to 274 in 8a1052a

	if (ReportUtils.isClosedReport(report)) {
	return CONST.SEARCH.ACTION_TYPES.DONE;
	}

and Done will be displayed.

What changes do you think we should make in order to solve the problem?

Change this line

App/src/libs/actions/IOU.ts

Line 7274 in 5e52372

const statusNum: ValueOf<typeof CONST.REPORT.STATUS_NUM> = approvalMode === CONST.POLICY.APPROVAL_MODE.OPTIONAL ? CONST.REPORT.STATUS_NUM.CLOSED : CONST.REPORT.STATUS_NUM.APPROVED;

    const statusNum: ValueOf<typeof CONST.REPORT.STATUS_NUM> = approvalMode === CONST.POLICY.APPROVAL_MODE.OPTIONAL ? CONST.REPORT.STATUS_NUM.SUBMITTED : CONST.REPORT.STATUS_NUM.APPROVED;

What alternative solutions did you explore? (Optional)

[melvin-bot]

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[mountiny]

I dont think this is BE blocker based on the video

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[dangrous]

oh hai, not sure why i was double assigned? @puneetlath are you okay to take this one? I think you were here first.

[puneetlath]

I think it assigned me and you because I'm on the BZ team as well as engineering. So I got assigned as the BZ. You got assigned as the engineer.

Given that this Pay button in search is a new feature that isn't even on prod yet, I don't think this needs to be a deploy blocker. We can clean it up as a follow up. cc @luacmartins

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021856449395622318059

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[luacmartins]

I'll handle this since I'm the author of the offending PR.

[Nodebrute]

@luacmartins Hey! Just wanted to let you know this issue isn't coming from your PR. Offending pr: #48700

[luacmartins]

Ah nice! I'll make it external again then! cc @cretadn22 @tgolen @situchan

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[melvin-bot]

📣 @suneox 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dangrous]

Just to confirm here, this is a standard external issue now, with me as eng, @puneetlath as bug zero, and @suneox as C+?

[puneetlath]

Correct!