[$62.50] Web - Chat - Error message not translated when changing language

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.59-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Log in to any account using two tabs
2. In the first tab, open any chat that contains a protected PDF
3. Click on the protected PDF, select "Enter password," and press Enter to trigger an error message
4. In the second tab, change the language to Spanish
5. Return to the first tab and observe the error message

Expected Result:

The error message should be translated to Spanish

Actual Result:

The error message remains in the original language and is not translated to Spanish

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6657900_1731001767296.Recording__4488.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021854646700760207529
• Upwork Job ID: 1854646700760207529
• Last Price Increase: 2024-11-07
• Automatic offers:
• Krishna2323 | Contributor | 104843295

Issue Owner

Current Issue Owner: @allroundexperts

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2024-11-07 20:21:16 UTC.

Proposal


Please re-state the problem that we are trying to solve in this issue.

Web - Chat - Error message not translated when changing language

What is the root cause of that problem?

• We are saving the translated text in validationErrorText state and due to this the error message is not recalculated when the language changes.
  

  App/src/components/PDFView/PDFPasswordForm.tsx

  Lines 48 to 56 in e3e4e53

  	const errorText = useMemo(() => {
  	if (isPasswordInvalid) {
  	return translate('attachmentView.passwordIncorrect');
  	}
  	if (validationErrorText) {
  	return validationErrorText;
  	}
  	return '';
  	}, [isPasswordInvalid, validationErrorText, translate]);

  
  

  App/src/components/PDFView/PDFPasswordForm.tsx

  Lines 88 to 95 in e3e4e53

  	const validate = () => {
  	if (!isPasswordInvalid && password) {
  	return true;
  	}
  	if (!password) {
  	setValidationErrorText(translate('attachmentView.passwordRequired'));
  	}
  	return false;

What changes do you think we should make in order to solve the problem?


• We should save the translation path in validationErrorText and return translate(validationErrorText); from errorText.

    const [validationErrorText, setValidationErrorText] = useState<TranslationPaths | null | ''>('');
    const errorText = useMemo(() => {
        if (isPasswordInvalid) {
            return translate('attachmentView.passwordIncorrect');
        }
        if (validationErrorText) {
            return translate(validationErrorText);
        }
        return '';
    }, [isPasswordInvalid, validationErrorText, translate]);
    
        const validate = () => {
        if (!isPasswordInvalid && password) {
            return true;
        }
        if (!password) {
            setValidationErrorText('attachmentView.passwordRequired');
        }
        return false;
    };

• We should also look for similar bugs in other places.

What alternative solutions did you explore? (Optional)

Result

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021854646700760207529

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[joekaufmanexpensify]

Very minor bug in somewhat niche flow, but we should fix it. Adjusting bounty downwards to reflect that this is a minor bug.

[Jaeta01]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01df91cefb9efad4cb

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[allroundexperts]

@Krishna2323's proposal looks good to me. Let's go with them.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @techievivek, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[joekaufmanexpensify]

@Krishna2323 Is there an ETA for the PR here?

[Krishna2323]

@allroundexperts, PR ready for review ^