[Search v1] Implement next step actions in Search

[luacmartins]

Problem

Navigating to reports to perform actions, e.g. submit, approve, pay is time consuming and cumbersome.

Solution

Allow users to perform actins straight from the search page

Blockers to be fixed:

• [Search v1.2] - When paying via search, changes are not seen in LHN and expense preview #52360
• [Search v1.2] - Pay button displayed next to expense after unapproving #52364
• [Search v1.2] - Button loads infinitely when approving or paying expense in Search in offline mode #52365
• [Search v1.2] - Paid invoice shows "View" button instead of "Paid" label #52366
• [Search v1.2] Invoice preview still shows "User owes x" after the invoice is paid #52367
• [Search v1.2] Android - Expense - Unexpected error when submitting expense to same WS after paying another #52368
• [Search v1.2] - Paid expenses do not have "Paid" label when the expenses are grouped expenses #52369
• [Search v1.2] - Pay button can be clicked many times without error when bank account is not set up #52371
• [Search v1.2] - LHN preview shows 0.00 and no pay button when paying partially from Search #52375
• [Search v1.2] - Unable to pay held expense in Search #52377
• [Search v1.2] - Approve button is not disabled in Search when "Prevent self-approvals" is enabled #52404
• [Search v1.2] - Approve button disappears after deleting expense in report that has comments #52411
• [Search v1.2] - Pay button appears for report that will be auto-paid and it reappears after clicked #52418

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @OfstadC (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[luacmartins]

It seems like the Auth PR made the Search command significantly slower. I'll look at logs next to see what the slow part is.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Show search action buttons #51445

If no regressions arise, payment will be issued on 2024-11-20. 🎊

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@OfstadC] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[luacmartins]

Ok, gonna start working on v2 since the original PR got reverted

[luacmartins]

I put up PRs for a bunch of the blockers today. There are still three to go though. Gonna work on that tomorrow.