[$250] Accounting - Unnecessary tooltip showing the same icon on export page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.55-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• A workspace with QBO or any accounting integration connected
• An expense created and paid

1. Go to transaction thread of the paid expense
2. Click on header > Export
3. Hover over the icon

Expected Result:

No tooltip should be shown

Actual Result:

Tooltip is shown showing the exact same icon that is already visible

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6649198_1730200163454.bandicam_2024-10-29_14-06-29-290.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021851328333556408802
• Upwork Job ID: 1851328333556408802
• Last Price Increase: 2024-11-12
• Automatic offers:
• Krishna2323 | Contributor | 104866520

Issue Owner

Current Issue Owner: @parasharrajat

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[NJ-2020]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Accounting - Unnecessary tooltip showing the same icon on export page

What is the root cause of that problem?

Inside ReportDetailsExportPage, we use the UserListItem component to render the items

App/src/pages/home/report/ReportDetailsExportPage.tsx

Lines 104 to 110 in b05ae2f

	<SelectionScreen<ExportType>
	policyID={policyID ?? ''}
	accessVariants={[CONST.POLICY.ACCESS_VARIANTS.ADMIN, CONST.POLICY.ACCESS_VARIANTS.PAID]}
	featureName={CONST.POLICY.MORE_FEATURES.ARE_CONNECTIONS_ENABLED}
	displayName={ReportDetailsExportPage.displayName}
	sections={[{data: exportSelectorOptions}]}
	listItem={UserListItem}

However we did not set the showTooltip to false, because inside UserListItem when rendering the icon

App/src/components/SelectionList/UserListItem.tsx

Lines 110 to 128 in b05ae2f

	{!!item.icons &&
	(item.shouldShowSubscript ? (
	<SubscriptAvatar
	mainAvatar={item.icons.at(0) ?? fallbackIcon}
	secondaryAvatar={item.icons.at(1)}
	showTooltip={showTooltip}
	backgroundColor={hovered && !isFocused ? hoveredBackgroundColor : subscriptAvatarBorderColor}
	/>
	) : (
	<MultipleAvatars
	icons={item.icons}
	shouldShowTooltip={showTooltip}
	secondAvatarStyle={[
	StyleUtils.getBackgroundAndBorderStyle(theme.sidebar),
	isFocused ? StyleUtils.getBackgroundAndBorderStyle(focusedBackgroundColor) : undefined,
	hovered && !isFocused ? StyleUtils.getBackgroundAndBorderStyle(hoveredBackgroundColor) : undefined,
	]}
	/>
	))}

We set the default showTooltip to true if the value is undefined

App/src/components/SubscriptAvatar.tsx

Line 62 in b05ae2f

showTooltip = true,

What changes do you think we should make in order to solve the problem?

We should pass showTooltip false inside ReportDetailsExportPage

function ExportListItems(props) {
    return <UserListItem showTooltip={false} {...props} />
}
...
<SelectionScreen<ExportType>
      policyID={policyID ?? ''}
      accessVariants={[CONST.POLICY.ACCESS_VARIANTS.ADMIN, CONST.POLICY.ACCESS_VARIANTS.PAID]}
      featureName={CONST.POLICY.MORE_FEATURES.ARE_CONNECTIONS_ENABLED}
      displayName={ReportDetailsExportPage.displayName}
      sections={[{data: exportSelectorOptions}]}
      listItem={ExportListItems}

What alternative solutions did you explore? (Optional)

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2024-10-29 13:45:40 UTC.

Proposal


Please re-state the problem that we are trying to solve in this issue.

Accounting - Unnecessary tooltip showing the same icon on export page

What is the root cause of that problem?

• We haven't passed the shouldRender prop inside MultipleAvatars component.
  

  App/src/components/MultipleAvatars.tsx

  Lines 150 to 155 in b05ae2f

  	<UserDetailsTooltip
  	accountID={Number(icons.at(0)?.id)}
  	icon={icons.at(0)}
  	fallbackUserDetails={{
  	displayName: icons.at(0)?.name,
  	}}

  
  

  App/src/components/MultipleAvatars.tsx

  Lines 190 to 196 in b05ae2f

  	<UserDetailsTooltip
  	key={`stackedAvatars-${icon.id}`}
  	accountID={Number(icon.id)}
  	icon={icon}
  	fallbackUserDetails={{
  	displayName: icon.name,
  	}}

  
  

  App/src/components/MultipleAvatars.tsx

  Lines 257 to 262 in b05ae2f

  	<UserDetailsTooltip
  	accountID={Number(icons.at(0)?.id)}
  	icon={icons.at(0)}
  	fallbackUserDetails={{
  	displayName: icons.at(0)?.name,
  	}}

  
  

  App/src/components/MultipleAvatars.tsx

  Lines 279 to 285 in b05ae2f

  	<UserDetailsTooltip
  	accountID={Number(icons.at(1)?.id)}
  	icon={icons.at(1)}
  	fallbackUserDetails={{
  	displayName: icons.at(1)?.name,
  	}}
  	>

What changes do you think we should make in order to solve the problem?


• Pass shouldRender={shouldShowTooltip} to all 4 UserDetailsTooltip components inside MultipleAvatars.
• We should also check for similar issues in components like MultipleAvatars.

What alternative solutions did you explore? (Optional)

Result

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unnecessary tooltip showing the same icon on export page

What is the root cause of that problem?

The integration icons are rendered by MultipleAvatars.tsx. Show Tooltips is passed as false to MultipleAvatars, but the value is not referenced when rendering the tooltip here:

App/src/components/MultipleAvatars.tsx

Lines 150 to 155 in b05ae2f

	<UserDetailsTooltip
	accountID={Number(icons.at(0)?.id)}
	icon={icons.at(0)}
	fallbackUserDetails={{
	displayName: icons.at(0)?.name,
	}}

What changes do you think we should make in order to solve the problem?

We will pass the shouldRender prop to UserDetailsTooltip on the page as:

shouldRender={shouldShowTooltips}

Additionally

• We will fix other tooltips, while checking if change doesn't cause a regression, fixing if it does.
• We will check other list items that may have this behaviour.

[Krishna2323]

PROPOSAL UPDATED

• I mistakenly wrote shouldRender={false} instead of shouldRender={shouldShowTooltip}. I've now updated the pseudocode. Sorry for that. The RCA and solution is the same.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021851328333556408802

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[parasharrajat]

Reviewing shortly.

[parasharrajat]

Back from festive holidays. I will check it now.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[parasharrajat]

@Krishna2323's proposal looks good to me. We will have to carefully check that this does not cause any issues as MultipleAvatar component is a generic component.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@parasharrajat @thienlnam @bfitzexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[parasharrajat]

@Krishna2323 Bump

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Krishna2323]

@parasharrajat, PR ready for review ^