[$250] Add a more inviting sign-off from Concierge after our onboarding messages so it looks good in the LHN

[jamesdeanexpensify]

Slack thread
https://expensify.slack.com/archives/C07HPDRELLD/p1729810967369919

Problem
For new users viewing the LHN, we draw attention to their Concierge chat with a GBR and "Get started here!" tooltip, which is great. However, the message preview from Concierge shows a task to complete depending on your onboarding intent selection. This is subjective, but it doesn't feel very welcoming/inviting, and also a bit strange and random.

Solution
Let's add a more inviting sign-off from Concierge after our onboarding messages (so it shows in the LHN message preview). It could be as simple as "It's great to meet you!"

Where I'm talking about

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021850951668861078961
• Upwork Job ID: 1850951668861078961
• Last Price Increase: 2024-11-04
• Automatic offers:
• shubham1206agra | Contributor | 104743508

Issue Owner

Current Issue Owner: @jasperhuangg

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021850951668861078961

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Anaslancer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add a more inviting sign-off from Concierge after our onboarding messages so it looks good in the LHN

What is the root cause of that problem?

There is no converting feature for greetings message instead of "task for ... ".

What changes do you think we should make in order to solve the problem?

• Add the greetings message like "It's great to meet you!" in English and Spanish at following file.
  https://github.com/Expensify/App/blob/main/src/languages/en.ts
  https://github.com/Expensify/App/blob/main/src/languages/es.ts
• if the lastMessageText is "task for Add personal bank account", we can change it as the greetings message that added in en.ts and es.ts.
  

  App/src/libs/SidebarUtils.ts

  Line 428 in da2e668

  let lastMessageText = Str.removeSMSDomain(lastMessageTextFromReport);

  
  We can change the static comparing text as dynamically.

What alternative solutions did you explore? (Optional)

N/A

Contributor details

Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01aff093c9a804b145

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[jamesdeanexpensify]

As additional info - You can see that, depending on which onboarding intent you select, there are various types of messages that finish with a task (or text) that we'll need to update by adding the sign-off "It's great to meet you!":

2024-10-28_15-05-14.mp4

2024-10-28_15-06-41.mp4

2024-10-28_15-08-42.mp4

(Note: the fourth option, "Chat and split expenses with friends," currently has a bug that's being addressed so we can leave that alone for now)

2024-10-28_15-10-33.mp4

[MuaazArshad]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A non-inviting sign-off from Concierge after our onboarding messages

What is the root cause of that problem?

We're treating Concierge as a standard chat by generating its most recent message based on recent activity, while also considering the first message as part of its activity history.

What changes do you think we should make in order to solve the problem?

We should add a separate condition for Concierge. We can add it like

if(result.isConciergeChat && lastAction?.actionName === CONST.REPORT.ACTIONS.TYPE.ADD_COMMENT) {
            result.alternateText = "It's great to meet you!";
        } 

Surely after taking care of the translation. Before this line

App/src/libs/SidebarUtils.ts

Lines 497 to 500 in db592c9

	result.alternateText =
	(ReportUtils.isGroupChat(report) || ReportUtils.isDeprecatedGroupDM(report)) && lastActorDisplayName
	? ReportUtils.formatReportLastMessageText(Parser.htmlToText(`${lastActorDisplayName}: ${lastMessageText}`))
	: ReportUtils.formatReportLastMessageText(Parser.htmlToText(lastMessageText)) || formattedLogin;

What alternative solutions did you explore? (Optional)

[Anaslancer]

@jamesdeanexpensify Yes, I can handle it. We can add these lines at the SidebarUtils.ts.

import type * as OnyxTypes from '@src/types/onyx';

let introSelected: OnyxEntry<OnyxTypes.IntroSelected>;   // for getting what user selected on onboarding
Onyx.connect({
    key: ONYXKEYS.NVP_INTRO_SELECTED,
    callback: (value) => (introSelected = value),
});

And add this code below line 428

App/src/libs/SidebarUtils.ts

Line 428 in da2e668

let lastMessageText = Str.removeSMSDomain(lastMessageTextFromReport);

    let onboardingPurpose = introSelected?.choice;
    if (onboardingPurpose) {
        const onboardingMessages: ValueOf<typeof CONST.ONBOARDING_MESSAGES> = CONST.ONBOARDING_MESSAGES[onboardingPurpose];
        const tasks = onboardingMessages.tasks;
        const comparingText = tasks.length ? `task for ${tasks.slice(-1)[0].title}` : onboardingMessages.message;
        
        if (lastMessageText == comparingText) {
            lastMessageText = "It's great to meet you!";
        }
    }

Then we can see these videos with a greetings message. but we should add the "It's great to meet you!" in the en.ts and es.ts files.

[Anaslancer]

Get.Employee.mp4

Manage.Team.mp4

Track.Expense.mp4

[lschurr]

@situchan can you review the proposals here?

[situchan]

I don't like any of the proposed solutions so far. They will cause regressions when user sends any message to Concierge chat.
Greetings message should show in LHN only when there's only onboarding task, no other report actions.

[Anaslancer]

@situchan I just changed the condition.

    const accountID = session?.accountID;
    let onboardingPurpose = introSelected?.choice;
    if (onboardingPurpose && result.isConciergeChat && report.lastActorAccountID != accountID) {
        const onboardingMessages: ValueOf<typeof CONST.ONBOARDING_MESSAGES> = CONST.ONBOARDING_MESSAGES[onboardingPurpose];
        const tasks = onboardingMessages.tasks;
        const comparingText = tasks.length ? `task for ${tasks.slice(-1)[0].title}` : onboardingMessages.message;
        
        if (lastMessageText.substring(0, 20) == comparingText.substring(0, 20)) {
            lastMessageText = "It's great to meet you!";
        }
    }

result.isConciergeChat : for detecting if Concierge chat
report.lastActorAccountID != accountID : in Concierge chat, for detecting if reported user is a logged in user.

[Anaslancer]

[situchan]

I think we should show It's great to meet you! message only when report meets these conditions:

• concierge chat
• there are no report actions whose actorAcountID is not 8392101 (concierge account id)
• last visible report action's childType = task
• there are no other report actions whose childType = task

This guarantees that user just finished onboarding after sign up.
@jamesdeanexpensify @jasperhuangg What do you think?

[ugogiordano]

@situchan, I believe your third point is covered by point four. Instead, you can simply check if there is at least one report with a child type of 'task.' If so, it indicates that the user has not completed the onboarding tasks.

So, if i understood correctly, you mean something like this:

    if (optionItem?.isConciergeChat && isOnboardingCompleted && ReportActionsUtils.areOnboardingTasksCompleted(optionItem.reportID)) {
        optionItem.alternateText = translate('onboarding.welcomeSignOffTitle');
    }

function areOnboardingTasksCompleted(reportID: string): boolean {
    const reportActions = Object.values(allReportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`] ?? {});
    const areAllReportActionsFromConcierge = reportActions.every((ra) => ra.actorAccountID === CONST.ACCOUNT_ID.CONCIERGE);
    const hasPendingTasks = reportActions.some((ra) => ra.childType === CONST.REPORT.TYPE.TASK);
    return areAllReportActionsFromConcierge && !hasPendingTasks;
}

[Anaslancer]

@situchan I don't think your conditions(3 and 4) are correct, because when a user select an last item ("Something else") on the onboarding, I think that is not a task.

last visible report action's childType = task
there are no other report actions whose childType = task

And I checked the conditions (1 and 2)

if (onboardingPurpose && result.isConciergeChat && report.lastActorAccountID != accountID) {

[situchan]

@situchan I don't think your conditions(3 and 4) are correct, because when a user select an last item ("Something else") on the onboarding, I think that is not a task.

Should we still show welcome message even when nothing shows?

[Anaslancer]

@situchan I think yes, according to this;
#51501 (comment)
Please check the last video.

[situchan]

@jamesdeanexpensify can you please confirm #51501 (comment)?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[jamesdeanexpensify]

@situchan I think if they choose "Something else" as the onboarding option, we can still end that message with "It's great to meet you!" It makes sense to me.

[melvin-bot]

@jamesdeanexpensify, @jasperhuangg, @lschurr, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[jasperhuangg]

Mostly OOO today because I hurt my foot and I'm at the hospital getting it checked out.

@situchan Are the next steps here to wait for a proposal that aligns with the clarified requirements?

[situchan]

I will be OOO soon so it's better to reassign C+ since I won't be available by the time the PR will be up

[melvin-bot]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[shubham1206agra]

@jamesdeanexpensify @jasperhuangg Can we just simply hide the task messages in Concierge chat in LHN?
It will now show Welcome to Expensify as alternative text.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add a more inviting sign-off from Concierge after our onboarding messages so it looks good in the LHN

What is the root cause of that problem?

App/src/libs/OptionsListUtils.ts

Lines 623 to 628 in 10454f0

	} else if (ReportActionUtils.isCreatedTaskReportAction(lastReportAction)) {
	lastMessageTextFromReport = TaskUtils.getTaskCreatedMessage(lastReportAction);
	} else if (
	ReportActionUtils.isActionOfType(lastReportAction, CONST.REPORT.ACTIONS.TYPE.SUBMITTED) ||
	ReportActionUtils.isActionOfType(lastReportAction, CONST.REPORT.ACTIONS.TYPE.SUBMITTED_AND_CLOSED)
	) {

We display the task message as alternative text in LHN if the last action is the created task report.

What changes do you think we should make in order to solve the problem?

1. Create a new translation key for It's great to meet you! message

2. If the report is the concierge chat and the created task action is the onboarding task, we will return It's great to meet you! message or the welcome message text for concierge chat

else if (ReportActionUtils.isCreatedTaskReportAction(lastReportAction)) {
    if (ReportUtils.isConciergeChatReport(report) && Object.values(introSelected ?? {}).includes(lastReportAction?.childReportID ?? '-1')) {
        lastMessageTextFromReport = Localize.translateLocal(newTranslationKey); // newTranslationKey is the new translation key for `It's great to meet you!` message
    } else {
        lastMessageTextFromReport = TaskUtils.getTaskCreatedMessage(lastReportAction);
    }
}

App/src/libs/OptionsListUtils.ts

Lines 623 to 628 in 10454f0

	} else if (ReportActionUtils.isCreatedTaskReportAction(lastReportAction)) {
	lastMessageTextFromReport = TaskUtils.getTaskCreatedMessage(lastReportAction);
	} else if (
	ReportActionUtils.isActionOfType(lastReportAction, CONST.REPORT.ACTIONS.TYPE.SUBMITTED) ||
	ReportActionUtils.isActionOfType(lastReportAction, CONST.REPORT.ACTIONS.TYPE.SUBMITTED_AND_CLOSED)
	) {

Or if we want to always show this message in LHN for concierge chat we can add a case in getLastMessageTextForReport function to return early if the report is concierge chat

else if (ReportUtils.isConciergeChatReport(report)) {
    lastMessageTextFromReport = Localize.translateLocal(newTranslationKey);
}

What alternative solutions did you explore? (Optional)

[mkzie2]

@jamesdeanexpensify When do we want to show the It's great to meet you! message in LHN?

1. Always
2. Only show it if the last action in the concierge chat is the onboarding task

[jamesdeanexpensify]

Oh this might actually work! Every new account gets that message regardless.

[Anaslancer]

@jamesdeanexpensify My proposal works for every onboarding tasks.
And I attached all videos

[shubham1206agra]

Waiting for @jasperhuangg confirmation on #51501 (comment)

[melvin-bot]

@jamesdeanexpensify, @jasperhuangg, @lschurr, @shubham1206agra Huh... This is 4 days overdue. Who can take care of this?

[shubham1206agra]

Waiting for @jasperhuangg confirmation on #51501 (comment)

[jasperhuangg]

Sorry for the late response! Yeah I think that would work, I don't see why hiding the task messages would hinder anything. We can catch any weirdness in the PR with thorough testing.

[shubham1206agra]

Please adjust the logic everyone.

[mkzie2]

@shubham1206agra Although we can hide the task message in LHN, what is the message that we want to show in this LHN? Because after the onboarding is complete, we have other actions before the task action.