-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Hybrid app - Chat - App crashes when receiving a Split request #50670
Comments
Triggered auto assignment to @bondydaa ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
We think that this bug might be related to #vip-bills |
@lanitochka17 can you confirm if this is only happeninng on hybrid app? or does it also happen for the new dot specific ios app? that will help us try to narrow down which code base to look into |
Job added to Upwork: https://www.upwork.com/jobs/~021844807954503108910 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 ( |
we think this may be related #50279 |
looks like this is not reproducible on New Dot alone so is most likely related to just hybrid app |
Should this be |
removed new dot deploy blocker since this is only related to hybrid. seeing if @Julesssss or @AndrewGable can help me out on this then. |
I think this was meant to say send a "split request" not a "split screen request"? Though that would be interesting feature to add 😄 |
Hey @bondydaa I haven't yet shared a wider message, but HybridApp blockers should block App deploys now. We'll need to fix this still |
Initially, I didn't re-add it because we've already 'shipped' it to HybridApp... but as our HybridApp deploys are Ad-Hoc I think it is worth re-adding the label 👍 Here's a comment I shared with Lucien last time we had a HybridApp blocker, hopefully that helps a little bit: This is a HybridApp bug that blocks HybridApp from being release. We will treat this as a NewDot blocker, as the regression was caused by a newDot PR on the current checklist and it blocks us from shipping HybridApp releases/fixes. This is the first step in a new process we have been planning for, and @andrew and myself are here to help to document any difficulties or questions that arise. Here is a Stackoverflow post that documents some tips and differences in the triage process. |
Issue is not reproducible now ScreenRecording_10-16-2024.01-05-12_1.MP4 |
@Julesssss Maybe we can close this since it is not reproducible anymore? |
It looks like HybridApp hasn't been tested, just NewDot. From the comments in this issue it sounds like the crash was occurring on HybridApp Hi @lanitochka17, it looks like the screen capture was on NewDot. Could you please verify for HybridApp too? (this isn't very clear on the issue desctiption) |
little bump @lanitochka17 to test on HybridApp |
@adelekennedy Issue is not still reproducible on the latest build 9.0.53-1 ScreenRecording_10-16-2024.01-05-12_1.1.MP4 |
@adelekennedy this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
@adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
I think we are good to close - anyone who thinks there are additional steps needed (or any payouts I missed) please reopen! |
Issue is still reproducible on the latest build 9.0.56-0 IMG_0826.MP4 |
@adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@bondydaa @Julesssss it looks like this has popped back up |
@bondydaa, @Julesssss, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.48 Hybrid OD app
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5076319
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
The split request is received without issues
Actual Result:
The app crashes before or after the split request is shown on screen
THIS seems to be crashed the HybridApp
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6632014_1728663793431.Recording__1076.mp4
Bug6632014_1728663793410.RPReplay_Final1728663195.mp4
logs (2).txt
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @c3024The text was updated successfully, but these errors were encountered: