Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Hybrid app - Chat - App crashes when receiving a Split request #50670

Open
2 of 8 tasks
lanitochka17 opened this issue Oct 11, 2024 · 42 comments
Open
2 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Needs Reproduction Reproducible steps needed Overdue

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 11, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.48 Hybrid OD app
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5076319
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

  1. Login to two devices
  2. Keep you iOS app on foreground
  3. From the second device send a split request

Expected Result:

The split request is received without issues

Actual Result:

The app crashes before or after the split request is shown on screen

THIS seems to be crashed the HybridApp

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: HybridApp
  • Android: Native
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6632014_1728663793431.Recording__1076.mp4
Bug6632014_1728663793410.RPReplay_Final1728663195.mp4

logs (2).txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021844807954503108910
  • Upwork Job ID: 1844807954503108910
  • Last Price Increase: 2024-10-11
Issue OwnerCurrent Issue Owner: @c3024
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Oct 11, 2024
Copy link

melvin-bot bot commented Oct 11, 2024

Triggered auto assignment to @bondydaa (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Oct 11, 2024

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-bills

@bondydaa
Copy link
Contributor

@lanitochka17 can you confirm if this is only happeninng on hybrid app? or does it also happen for the new dot specific ios app? that will help us try to narrow down which code base to look into

@bondydaa bondydaa added the External Added to denote the issue can be worked on by a contributor label Oct 11, 2024
@melvin-bot melvin-bot bot changed the title Hybrid app - Chat - App crashes when receiving a Split request [$250] Hybrid app - Chat - App crashes when receiving a Split request Oct 11, 2024
Copy link

melvin-bot bot commented Oct 11, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021844807954503108910

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 11, 2024
Copy link

melvin-bot bot commented Oct 11, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

@bondydaa
Copy link
Contributor

we think this may be related #50279

cc @DylanDylann @christianwen

@bondydaa
Copy link
Contributor

https://expensify.slack.com/archives/C01GTK53T8Q/p1728672481520729?thread_ts=1728668847.513159&cid=C01GTK53T8Q

looks like this is not reproducible on New Dot alone so is most likely related to just hybrid app

@c3024
Copy link
Contributor

c3024 commented Oct 13, 2024

Should this be Internal? External contributors cannot access Hybrid App Mobile-Expensify repo.

@bondydaa bondydaa removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Oct 14, 2024
@bondydaa bondydaa added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Oct 14, 2024
@bondydaa
Copy link
Contributor

removed new dot deploy blocker since this is only related to hybrid. seeing if @Julesssss or @AndrewGable can help me out on this then.

@marcaaron
Copy link
Contributor

From the second device send a split screen request

I think this was meant to say send a "split request" not a "split screen request"? Though that would be interesting feature to add 😄

@Julesssss
Copy link
Contributor

removed new dot deploy blocker since this is only related to hybrid. seeing if @Julesssss or @AndrewGable can help me out on this then.

Hey @bondydaa I haven't yet shared a wider message, but HybridApp blockers should block App deploys now. We'll need to fix this still

@Julesssss
Copy link
Contributor

Initially, I didn't re-add it because we've already 'shipped' it to HybridApp... but as our HybridApp deploys are Ad-Hoc I think it is worth re-adding the label 👍

Here's a comment I shared with Lucien last time we had a HybridApp blocker, hopefully that helps a little bit:


This is a HybridApp bug that blocks HybridApp from being release. We will treat this as a NewDot blocker, as the regression was caused by a newDot PR on the current checklist and it blocks us from shipping HybridApp releases/fixes.

This is the first step in a new process we have been planning for, and @andrew and myself are here to help to document any difficulties or questions that arise. Here is a Stackoverflow post that documents some tips and differences in the triage process.

@bondydaa
Copy link
Contributor

@lanitochka17
Copy link
Author

Issue is not reproducible now

ScreenRecording_10-16-2024.01-05-12_1.MP4

@pecanoro
Copy link
Contributor

@Julesssss Maybe we can close this since it is not reproducible anymore?

@Julesssss
Copy link
Contributor

Julesssss commented Oct 17, 2024

@Julesssss Maybe we can close this since it is not reproducible anymore?

It looks like HybridApp hasn't been tested, just NewDot. From the comments in this issue it sounds like the crash was occurring on HybridApp

Hi @lanitochka17, it looks like the screen capture was on NewDot. Could you please verify for HybridApp too? (this isn't very clear on the issue desctiption)

@melvin-bot melvin-bot bot added the Overdue label Oct 21, 2024
@adelekennedy
Copy link

little bump @lanitochka17 to test on HybridApp

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 22, 2024
@lanitochka17
Copy link
Author

lanitochka17 commented Oct 24, 2024

@adelekennedy Issue is not still reproducible on the latest build 9.0.53-1

ScreenRecording_10-16-2024.01-05-12_1.1.MP4

Copy link

melvin-bot bot commented Oct 25, 2024

@adelekennedy this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Oct 25, 2024

@adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@adelekennedy
Copy link

I think we are good to close - anyone who thinks there are additional steps needed (or any payouts I missed) please reopen!

@lanitochka17
Copy link
Author

lanitochka17 commented Oct 31, 2024

Issue is still reproducible on the latest build 9.0.56-0

IMG_0826.MP4

logs.txt

@lanitochka17 lanitochka17 reopened this Oct 31, 2024
@melvin-bot melvin-bot bot added the Overdue label Nov 4, 2024
Copy link

melvin-bot bot commented Nov 4, 2024

@adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

@adelekennedy
Copy link

@bondydaa @Julesssss it looks like this has popped back up

@melvin-bot melvin-bot bot added the Overdue label Nov 11, 2024
Copy link

melvin-bot bot commented Nov 12, 2024

@bondydaa, @Julesssss, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@Julesssss Julesssss removed their assignment Nov 12, 2024
@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Needs Reproduction Reproducible steps needed Overdue
Projects
None yet
Development

No branches or pull requests

9 participants