-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distance - App crashes after selecting rate that has no Tax rate & Tax reclaimable on #49556
Comments
Triggered auto assignment to @OfstadC ( |
We think that this bug might be related to #wave-collect - Release 1 |
@OfstadC FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
ProposalPlease re-state the problem that we are trying to solve in this issue.Distance - App crashes after selecting rate that has no Tax rate & Tax reclaimable on What is the root cause of that problem?We are not adding optional chaining before Line 3477 in 513e6b3
What changes do you think we should make in order to solve the problem?Add optional chaining before value
What alternative solutions did you explore? (Optional) |
ProposalPlease re-state the problem that we are trying to solve in this issue.App crashes after selecting distance rate that has no Tax rate and Tax reclaimable on. What is the root cause of that problem?When track tax is enabled and we select the rate that has no tax rate, App/src/pages/iou/request/step/IOURequestStepDistanceRate.tsx Lines 95 to 107 in 513e6b3
Then here we passed it to Lines 3176 to 3180 in 513e6b3
Then the app crashes here because Lines 3475 to 3477 in 8383570
What changes do you think we should make in order to solve the problem?Safely get the value field here
Lines 3475 to 3477 in 8383570
And we can fallback taxRateExternalID as empty string
App/src/pages/iou/request/step/IOURequestStepDistanceRate.tsx Lines 95 to 107 in 513e6b3
or add a check here to not add
Lines 3176 to 3180 in 513e6b3
What alternative solutions did you explore? (Optional)NA |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.39-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
App will not crash.
Actual Result:
App crashes after selecting distance rate that has no Tax rate and Tax reclaimable on.
Crash happens when the rate has
Workaround:
Unknown
Platforms:
Screenshots/Videos
2009_1.txt
Bug6610205_1726857577201.ScreenRecording_09-21-2024_02-34-46_1.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: