Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approver - Next step message for the approver is not displayed #49552

Open
2 of 6 tasks
IuliiaHerets opened this issue Sep 20, 2024 · 4 comments
Open
2 of 6 tasks

Approver - Next step message for the approver is not displayed #49552

IuliiaHerets opened this issue Sep 20, 2024 · 4 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.39-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4991111
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. Create a workspace with an approver.
  2. Make the approver the approver of the workspace

OD configuration

  1. As the admin in OldDot - Navigate to members
  2. Under "Workflow enforcement" enable "Prevent Self Approval"

NewDot - Admin Approver

  1. Login as the Approver
  2. Navigate to the workspace chat
  3. Submit expense from the workspace
  4. Click on the report that was created

Expected Result:

There is a hour glass with a comment: "Oops! Looks like you're submitting to yourself. Approving your own reports is forbidden by your policy. Please submit this report to someone else or contact your admin to change the person you submit to." and label is "Next Steps"."

Actual Result:

A message is not display to the approver that they're not allowed to submit reports to themselves if the Enable self Approval is enabled in the workspace.
Issue doesn't happen with the US tester.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6610193_1726856944474.2024-09-20_21.26.48.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 20, 2024
Copy link

melvin-bot bot commented Sep 20, 2024

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@IuliiaHerets
Copy link
Author

@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lschurr lschurr removed the Bug Something is broken. Auto assigns a BugZero manager. label Sep 20, 2024
@lschurr lschurr removed their assignment Sep 20, 2024
@lschurr lschurr added the Bug Something is broken. Auto assigns a BugZero manager. label Sep 20, 2024
@lschurr
Copy link
Contributor

lschurr commented Sep 20, 2024

I'm heading OOO from 9/23-10/4 so I need to reassign this one.

Copy link

melvin-bot bot commented Sep 20, 2024

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

3 participants