[$250] Room-A "workspace" visibility room is created via whisper from a "public" visibility room

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.39-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Tap fab -- start chat
3. Create a public visibility room
4. Create 2 room via whisper by sending message - eg : #35 #799
5. From the whisper message, tap yes
6. Note room created is highlighted
7. Now tap on room header -- settings -- visibility
8. Note room is a "public" visibility room
9. Now tap on any room highlighted ( created via whisper)
10. Now tap on room header -- settings -- visibility
11. Note room created is a workspace visibility room

Expected Result:

A "public" visibility room must be created via whisper from a "public" visibility room.

Actual Result:

A "workspace" visibility room is created via whisper from a "public" visibility room.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6609907_1726835399664.screenrecorder-2024-09-20-16-47-00-591_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021837194850505873695
• Upwork Job ID: 1837194850505873695
• Last Price Increase: 2024-09-20

Issue Owner

Current Issue Owner: @DylanDylann

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Christinadobrzyn]

I can reproduce this with the steps in the OP. I think this can be external - let's start there and see what we think!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021837194850505873695

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

A "workspace" visibility room is created via whisper from a "public" visibility room.

What is the root cause of that problem?

When we click on Yes, BE will create a room with visibility as restricted

What changes do you think we should make in order to solve the problem?

In this function, if resolution is created, we should create an optimistic room with visibility as the visibility of the current report and a created action for this room in optimistic data (Also reset it in failure data).

App/src/libs/actions/Report.ts

Lines 3883 to 3887 in 513e6b3

	function resolveActionableReportMentionWhisper(
	reportId: string,
	reportAction: OnyxEntry<ReportAction>,
	resolution: ValueOf<typeof CONST.REPORT.ACTIONABLE_REPORT_MENTION_WHISPER_RESOLUTION>,
	) {

Then we can pass the reportID and visibility of the new room as a param of ResolveActionableReportMentionWhisper API. BE will use this reportID and visibility to create a new room.

What alternative solutions did you explore? (Optional)

If we don't want to create an optimistic room, we can pass visibility param to ResolveActionableReportMentionWhisper API then BE can use this to create the room with the correct visibility.