Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag rules - Tag rules are available for multi tags when the rules are not present on Old Dot #49543

Open
6 tasks done
IuliiaHerets opened this issue Sep 20, 2024 · 14 comments
Open
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.39-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  • Rules are enabled
  • Dependent multi tags are set up on OD.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Tags.
  3. Click on any main tag.
  4. Click on any sub tag.

Expected Result:

Tag rules should not be available for multi tags (because the rules are not present on Old Dot).

Actual Result:

Tag rules are available for multi tags when the rules are not present on Old Dot.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6610082_1726848355301!Dependent_-_Multi_Level_tags_NEW.csv

Bug6610082_1726848355336.20240920_235201.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Sep 20, 2024
Copy link

melvin-bot bot commented Sep 20, 2024

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Sep 20, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Sep 20, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to #wave-control

Copy link

melvin-bot bot commented Sep 20, 2024

Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@deetergp deetergp removed the DeployBlockerCash This issue or pull request should block deployment label Sep 20, 2024
@deetergp
Copy link
Contributor

This is behind a beta so it's not a blocker.

cc @marcaaron

@deetergp deetergp added Daily KSv2 and removed Hourly KSv2 labels Sep 20, 2024
@marcaaron
Copy link
Contributor

I'm also slightly confused about why we don't allow approvers on multi-level tags. Maybe there's just not much overlap or it would be strange to potentially have multiple approvers? @JmillsExpensify what do you think about this one?

@marcaaron
Copy link
Contributor

I'm not able to reproduce this on main fwiw. @yuwenmemon is working on tags related features for NewDot, maybe we can ask him to keep an eye on this.

@marcaaron
Copy link
Contributor

2024-09-20_09-19-09

maybe this has something to do with multiple policy set up with different configurations?

@IuliiaHerets
Copy link
Author

@marcaaron Policy should be Control, you can enable Rules in More features to upgrade it

@marcaaron
Copy link
Contributor

Yes. Tested with a Control policy. The provided steps do not lead to a reproduction.

@IuliiaHerets
Copy link
Author

Issue is still reproducible, tested just now

bandicam.2024-09-20.23-07-06-209.mp4

@strepanier03 strepanier03 added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Sep 21, 2024
@strepanier03 strepanier03 removed their assignment Sep 21, 2024
@strepanier03 strepanier03 removed the Bug Something is broken. Auto assigns a BugZero manager. label Sep 21, 2024
Copy link

melvin-bot bot commented Sep 21, 2024

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@strepanier03 strepanier03 added the Bug Something is broken. Auto assigns a BugZero manager. label Sep 21, 2024
Copy link

melvin-bot bot commented Sep 21, 2024

Current assignee @bfitzexpensify is eligible for the Bug assigner, not assigning anyone new.

@strepanier03
Copy link
Contributor

@bfitzexpensify - I am going OoO until the 3rd of October and I didn't get to this before I headed out. Thanks for taking over 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

5 participants