Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExpensiMark: potential bug with highlighting @here followed by a single letter #31180

Closed
tomekzaw opened this issue Nov 10, 2023 · 4 comments
Closed
Assignees
Labels
Engineering Improvement Item broken or needs improvement. Monthly KSv2

Comments

@tomekzaw
Copy link
Contributor

tomekzaw commented Nov 10, 2023

Currently, ExpensiMark highlights @here even if the trailing character is not a punctuation character, for instance in @herea, but doesn't highlight it when there's two or more characters, e.g. @hereab.

Input 1: "@here"
Output 1: "<mention-here>@here</mention-here>"

Input 2: "@herea"
Output 2: "<mention-here>@here</mention-here>a"

Input 3: "@hereab"
Output 3: "@hereab"

The correct expected behavior would be not to highlight @here if the trailing character is a letter but still highlight it if it's a punctuation character like comma or exclamation mark.

Input: "@herea"
-Current output: "<mention-here>@here</mention-here>a"
+Desired output: "@herea"
Input: "@here!"
Output: "<mention-here>@here</mention-here>!"
Issue OwnerCurrent Issue Owner: @Skalakid
@tomekzaw tomekzaw changed the title ExpensiMark: potential bug with highlighting @here followed by a single letter ExpensiMark: potential bug with highlighting @here followed by a single letter Nov 10, 2023
@roryabraham roryabraham self-assigned this Nov 10, 2023
@roryabraham roryabraham added Monthly KSv2 Engineering Improvement Item broken or needs improvement. labels Nov 10, 2023
@roryabraham
Copy link
Contributor

Co-assigning myself to supervise, but this will be worked on by Michał Skałka from SWM

@Skalakid
Copy link
Contributor

Hi I’m Michał from Software Mansion, an expert agency, and I’d like to work on this issue

@roryabraham
Copy link
Contributor

Posted a thought about potentially reassigning this: https://expensify.slack.com/archives/C04878MDF34/p1703718815187329

@melvin-bot melvin-bot bot added the Overdue label Dec 27, 2023
@robertKozik
Copy link
Contributor

This issue was addressed by Expensify/expensify-common#603. I can't track the following PR for expensify/App, but based on the last version bump in package.json (DEC 15th), I think we can assume that the change from Expensify/expensify-common#603 is already deployed.

@melvin-bot melvin-bot bot removed the Overdue label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Monthly KSv2
Projects
Status: Done
Development

No branches or pull requests

4 participants