Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Safari mWeb - Keyboard won't open for some inputs (New Chat, Change Password, New Room) #10414

Closed
kbecciv opened this issue Aug 17, 2022 · 302 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Not a priority Reviewing Has a PR in review Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Aug 17, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing PR #10194

Action Performed:

case 1

  1. Access staging.new.expensify.com
  2. Sign into a valid user
  3. Click on the "Global action" button (Big green plus button in LHN)
  4. Click New Chat

case 2

  1. Go to https://staging.new.expensify.com/
  2. Login with expensifail account
  3. Create a Workspace
  4. Tap "+"
  5. Tap "New Room"

case 3

  1. Go to https://staging.new.expensify.com/
  2. Sign into a valid user
  3. Go to settings > security > change password

case 4

  1. Go to https://staging.new.expensify.com/
  2. Sign into a valid user
  3. Go to some DM
  4. Open the in app emoji picker
  5. Select some emoji

Expected Result:

Keyboard is open and cursor focused when entering the new screen

Actual Result:

Keyboard won't open

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Safari Mobile Web

Version Number: 1.1.88.13

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Case 1

Bug5691734_mWeb_10194.mp4

Case 2

Bug5773619_11587_mweb_ios.mp4

Case 3

RPReplay_Final1661701238.mov

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Tea

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2022

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@iwiznia iwiznia added the External Added to denote the issue can be worked on by a contributor label Aug 17, 2022
@iwiznia iwiznia removed their assignment Aug 17, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2022

Triggered auto assignment to @NicMendonca (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@NicMendonca
Copy link
Contributor

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Aug 18, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 18, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 18, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 18, 2022

Triggered auto assignment to @sketchydroide (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title mWeb - New chat - Keyboard won't open and cursor is not focused when click on New Chat/New Group [$250] mWeb - New chat - Keyboard won't open and cursor is not focused when click on New Chat/New Group Aug 18, 2022
@busyboxww
Copy link

The text is not having top "priority" or the list is getting auto focus. You should give change the layout, something zIndex or ... set focus programmatically.

@rushatgabhane
Copy link
Member

Interesting.. it tested well when I added screenshots for PR #10194

@rushatgabhane
Copy link
Member

I can't repro this bug on mWeb iOS, and mWeb Android.
v 1.1.89-1

mWeb iOS Safari

Screen.Recording.2022-08-25.at.1.12.34.AM.mov

mWeb Android Chrome

screen-20220825-010957.mp4

@melvin-bot
Copy link

melvin-bot bot commented Aug 24, 2022

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added the Overdue label Aug 26, 2022
@NicMendonca
Copy link
Contributor

@rushatgabhane are you recommending that I close this?

@melvin-bot melvin-bot bot removed the Overdue label Aug 26, 2022
@rushatgabhane
Copy link
Member

@NicMendonca not exactly. Let's close this bug if @kbecciv cannot repro it either

@kbecciv
Copy link
Author

kbecciv commented Aug 31, 2022

@rushatgabhane Issue is reproduced with latest build 1.1.94.4

RPReplay_Final1661904177.MP4

@melvin-bot melvin-bot bot added the Overdue label Sep 5, 2022
@parasharrajat
Copy link
Member

This is not yet solved.

@aldo-expensify aldo-expensify reopened this Jan 2, 2024
@sakluger
Copy link
Contributor

sakluger commented Feb 7, 2024

@kevinksullivan do you still think we should fix this one? And is it still an $8k bug? Just wanted to check in since it's been deprioritized since around October now.

@aldo-expensify
Copy link
Contributor

@kevinksullivan do you still think we should fix this one? And is it still an $8k bug? Just wanted to check in since it's been deprioritized since around October now.

Related slack conversation: https://expensify.slack.com/archives/C01SKUP7QR0/p1707765399023319

@kevinksullivan kevinksullivan changed the title [$8000] Safari mWeb - Keyboard won't open for some inputs (New Chat, Change Password, New Room) [$250] Safari mWeb - Keyboard won't open for some inputs (New Chat, Change Password, New Room) Feb 21, 2024
Copy link

melvin-bot bot commented Feb 21, 2024

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@kevinksullivan
Copy link
Contributor

kevinksullivan commented Feb 21, 2024

Changing price in GH as this has not been a priority. @kbecciv can you please confirm you can reproduce this still? Then we can source volunteers if necessary.

@eVoloshchak
Copy link
Contributor

Can confirm this is still reproducible on mWeb Safari for some inputs

Screen.Recording.2024-03-29.at.16.52.45.mov

@sakluger
Copy link
Contributor

sakluger commented Apr 3, 2024

@kevinksullivan fyi I added #25477 (which is held on this issue) to the vip-vsb project and I think this should be added to the same project since it's chat-related functionality.

@sakluger
Copy link
Contributor

Any updates here?

@sakluger
Copy link
Contributor

Friendlly bump - any updates?

@parasharrajat
Copy link
Member

parasharrajat commented Aug 4, 2024

There has been a lot of discussion on this issue. We had a PR to solve this which was abandoned #23922. I think we can open a fresh issue if we want to tackle this further.

@sakluger
Copy link
Contributor

@parasharrajat are you suggesting that we discuss whether we want to still solve this or just close the issue?

@kevinksullivan
Copy link
Contributor

@sakluger I will loop you in as BZ here if you don't mind, as I'm going OOO for a bit.

@sakluger
Copy link
Contributor

Sounds good. I'll ask @parasharrajat in Slack if we should close this issue.

@sakluger
Copy link
Contributor

We're going to close out the issue. Given all the work that's been done, @parasharrajat is eligible for the full $250 payment. I'll post a payment summary below.

@sakluger
Copy link
Contributor

Summarizing payment on this issue:

Contributor+: @parasharrajat $250, please request on Newdot

@parasharrajat
Copy link
Member

Payment requested as per #10414 (comment)

@JmillsExpensify
Copy link

$250 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Not a priority Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests