Deprecate enableBMFF API (backport) #2985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmilos
added
refactoring
kmilos
force-pushed
the
bp/deprecate_enablebmff_0.28
branch
from
7d35761
to
92cc125
Compare
|
Any interest in moving forward w/ this and releasing 0.28.3? @kevinbackhouse @neheb @nehaljwani |
|
Any idea why the "Mac Special Builds" failed? |
|
There's an open OSS-Fuzz issue that I need to investigate. I'll do that this evening. If it affects the 0.28.x branch and not just main, then I'd like to include that in 0.28.3 too please. |
Sure.
I think it started happening when the |
# Conflicts: # src/bmffimage.cpp
kmilos
force-pushed
the
bp/deprecate_enablebmff_0.28
branch
from
92cc125
to
d69e72d
Compare
kevinbackhouse
approved these changes
Jul 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #2981 and #2982