In src/futils.cpp Added #include <cstdint> #2968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this now required because of GCC 14 header refactoring? |
|
Well, can't tell. But without it, my compilation stopped, complaining about the fixed integer types (defined in cstdint>). I use both g++ 13.2.1 and clang++ (18.0.0 and 19.0.0).
Regards,
Bertwim
… On 16/05/2024 12:18 PM CEST Miloš Komarčević ***@***.***> wrote:
Is this now required because of GCC 14 header refactoring https://gcc.gnu.org/gcc-14/porting_to.html#header-dep-changes?
—
Reply to this email directly, view it on GitHub #2968 (comment), or unsubscribe https://github.com/notifications/unsubscribe-auth/AABDMW2VXLTU235LO5O6CVTZCSBXRAVCNFSM6AAAAABHZXFKS2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJUHAYDMNRZGA.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Strange, because our CI runs GCC 13 and Clang 18 already w/o problems, see e.g. these jobs. What system is this? |
|
Yes, it is strange indeed. I have a Linux OpenSuse leap 15.4 system. I have observed also on other systems (sorry, don't know the details anymore) that apparently compilers sometimes do have different opinions if an earlier indirectly included file is stil 'valid'. It strangely enough may even depend on optimization level, which is also weird.
But don't you think the <cstdint> should be included anyway, as in the same file contents from it is being used? I would call that good practice.
Kind Regards,
Bertwim
… On 16/05/2024 1:08 PM CEST Miloš Komarčević ***@***.***> wrote:
Strange, because our CI runs GCC 13 and Clang 18 already, see e.g. these jobs https://github.com/Exiv2/exiv2/actions/runs/9096801505. What system is this?
—
Reply to this email directly, view it on GitHub #2968 (comment), or unsubscribe https://github.com/notifications/unsubscribe-auth/AABDMWZMHYIMB2DXMMJEKLDZCSHTNAVCNFSM6AAAAABHZXFKS2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJUHEZTMOBSGI.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sure. |
kmilos
approved these changes
May 16, 2024
|
@mergify backport 0.28.x |
✅ Backports have been created
|
kmilos
added
the
compilers
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the standard include file containing the declarations of fied width integer type, uint8_t etc.