Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lens): canon lens detecton should be independent of locale (backport #2938) #2942

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Apr 2, 2024

Backport of pull request #2938

@kmilos kmilos requested review from neheb and hassec April 2, 2024 12:02
@kmilos kmilos added lens Issue related to lens detection bug i18n Internationalisation labels Apr 2, 2024
@kmilos kmilos added this to the v0.28.3 milestone Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 64.67%. Comparing base (f1632fe) to head (26e8d94).
Report is 2 commits behind head on 0.28.x.

Files Patch % Lines
src/canonmn_int.cpp 68.75% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           0.28.x    #2942   +/-   ##
=======================================
  Coverage   64.66%   64.67%           
=======================================
  Files         104      104           
  Lines       22169    22180   +11     
  Branches    10839    10846    +7     
=======================================
+ Hits        14335    14344    +9     
- Misses       5590     5591    +1     
- Partials     2244     2245    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neheb neheb merged commit 070c588 into 0.28.x Apr 2, 2024
57 of 61 checks passed
@neheb neheb deleted the bp/pr-2938 branch April 2, 2024 17:12
@kmilos kmilos mentioned this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug i18n Internationalisation lens Issue related to lens detection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants