Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic UTF-8 type #2740

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add basic UTF-8 type #2740

wants to merge 1 commit into from

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Aug 8, 2023

Part of #2659

This is the most basic type recognition, there's probably a bunch of string sub-classing required.

@ghost
Copy link

ghost commented Aug 8, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #2740 (0279962) into main (6ea6e2c) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2740      +/-   ##
==========================================
- Coverage   63.91%   63.89%   -0.02%     
==========================================
  Files         103      103              
  Lines       22312    22315       +3     
  Branches    10805    10806       +1     
==========================================
- Hits        14260    14259       -1     
- Misses       5830     5833       +3     
- Partials     2222     2223       +1     
Files Changed Coverage Δ
include/exiv2/types.hpp 82.05% <ø> (ø)
src/image.cpp 69.59% <0.00%> (-0.61%) ⬇️
src/types.cpp 95.53% <ø> (ø)

@kmilos kmilos marked this pull request as draft August 8, 2023 12:09
@kmilos kmilos mentioned this pull request Nov 19, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant