Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github CI: remove msvcrt (backport #2683) #2685

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 10, 2023

This is an automatic backport of pull request #2683 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

msvcrt support was effectively killed when wstring support was removed.
No need to test for it.

Signed-off-by: Rosen Penev <[email protected]>
(cherry picked from commit 50eca16)
@mergify mergify bot mentioned this pull request Jul 10, 2023
@ghost
Copy link

ghost commented Jul 10, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@kmilos kmilos merged commit e3f7509 into 0.28.x Jul 10, 2023
106 checks passed
@mergify mergify bot deleted the mergify/bp/0.28.x/pr-2683 branch July 10, 2023 10:46
@kevinbackhouse kevinbackhouse added this to the v0.28.1 milestone Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants