Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github CI: remove msvcrt #2683

Merged
merged 1 commit into from
Jul 9, 2023
Merged

github CI: remove msvcrt #2683

merged 1 commit into from
Jul 9, 2023

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Jul 7, 2023

msvcrt support was effectively killed when wstring support was removed. No need to test for it.

msvcrt support was effectively killed when wstring support was removed.
No need to test for it.

Signed-off-by: Rosen Penev <[email protected]>
@ghost
Copy link

ghost commented Jul 7, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #2683 (6fdc670) into main (901e8ba) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2683   +/-   ##
=======================================
  Coverage   63.89%   63.89%           
=======================================
  Files         103      103           
  Lines       22313    22313           
  Branches    10799    10799           
=======================================
  Hits        14258    14258           
  Misses       5830     5830           
  Partials     2225     2225           

@neheb neheb requested a review from kmilos July 8, 2023 21:25
@neheb neheb merged commit 50eca16 into Exiv2:main Jul 9, 2023
@neheb neheb deleted the mingw branch July 9, 2023 00:13
@kmilos
Copy link
Collaborator

kmilos commented Jul 10, 2023

@Mergifyio backport 0.28.x

@mergify
Copy link
Contributor

mergify bot commented Jul 10, 2023

backport 0.28.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants