Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove another if constexpr #2678

Closed
wants to merge 1 commit into from
Closed

remove another if constexpr #2678

wants to merge 1 commit into from

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Jul 4, 2023

More efficient before C++17

@ghost
Copy link

ghost commented Jul 4, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

More efficient before C++17

Signed-off-by: Rosen Penev <[email protected]>
@neheb
Copy link
Collaborator Author

neheb commented Jul 4, 2023

Hmm I'm not sure anymore.

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #2678 (97b9d86) into main (901e8ba) will increase coverage by 0.00%.
The diff coverage is 87.50%.

@@           Coverage Diff           @@
##             main    #2678   +/-   ##
=======================================
  Coverage   63.89%   63.90%           
=======================================
  Files         103      103           
  Lines       22313    22317    +4     
  Branches    10799    10801    +2     
=======================================
+ Hits        14258    14261    +3     
  Misses       5830     5830           
- Partials     2225     2226    +1     
Impacted Files Coverage Δ
include/exiv2/xmp_exiv2.hpp 86.36% <87.50%> (-2.53%) ⬇️

@neheb neheb closed this Jul 7, 2023
@neheb neheb deleted the constexpr branch July 7, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant