From 8158ec032cb92865067192eae21eb261d6e300ce Mon Sep 17 00:00:00 2001 From: Jay Chia Date: Tue, 1 Aug 2023 14:52:06 -0700 Subject: [PATCH] Re-enable non-anonymous mode which does retries, but add github action to assume credentials --- .github/workflows/python-package.yml | 6 ++++++ tests/integration/io/conftest.py | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml index 5591356fc4..1edeef4db8 100644 --- a/.github/workflows/python-package.yml +++ b/.github/workflows/python-package.yml @@ -242,6 +242,12 @@ jobs: run: | mkdir -p /tmp/daft-integration-testing/nginx chmod +rw /tmp/daft-integration-testing/nginx + - name: Assume GitHub Actions AWS Credentials + uses: aws-actions/configure-aws-credentials@v2 + with: + aws-region: us-west-2 + role-to-assume: ${{ secrets.ACTIONS_AWS_ROLE_ARN }} + role-session-name: DaftPythonPackageGitHubWorkflow - name: Spin up IO services uses: isbang/compose-action@v1.5.0 with: diff --git a/tests/integration/io/conftest.py b/tests/integration/io/conftest.py index da8967e348..ddf09ae17e 100644 --- a/tests/integration/io/conftest.py +++ b/tests/integration/io/conftest.py @@ -58,7 +58,7 @@ def nginx_config() -> tuple[str, pathlib.Path]: def retry_server_s3_config() -> daft.io.IOConfig: """Returns the URL to the local retry_server fixture""" return daft.io.IOConfig( - s3=daft.io.S3Config(endpoint_url="http://127.0.0.1:8001", anonymous=True), + s3=daft.io.S3Config(endpoint_url="http://127.0.0.1:8001"), )