From 4425196ba6546af82ba908ae9ec5484846690e36 Mon Sep 17 00:00:00 2001 From: Sammy Sidhu Date: Fri, 14 Jul 2023 16:49:30 -0700 Subject: [PATCH] [CHORE] Enable Parquet Integration tests for decimal types (#1161) * Enables Decimal Type Integration test * TODO: Still need Parquet Binary -> Decimal reading for old parquet files --- .../io/parquet/test_remote_reads.py | 36 +++++++++---------- 1 file changed, 16 insertions(+), 20 deletions(-) diff --git a/tests/integration/io/parquet/test_remote_reads.py b/tests/integration/io/parquet/test_remote_reads.py index e2721a4a79..d933992f4b 100644 --- a/tests/integration/io/parquet/test_remote_reads.py +++ b/tests/integration/io/parquet/test_remote_reads.py @@ -62,30 +62,26 @@ # "parquet-testing/data/fixed_length_byte_array.parquet", # "https://raw.githubusercontent.com/apache/parquet-testing/master/data/fixed_length_byte_array.parquet", # ), - # Need Decimal Support in Daft - # ( - # "parquet-testing/data/fixed_length_decimal.parquet", - # "https://raw.githubusercontent.com/apache/parquet-testing/master/data/fixed_length_decimal.parquet", - # ), - # Need Decimal Support in Daft - # ( - # "parquet-testing/data/fixed_length_decimal_legacy.parquet", - # "https://raw.githubusercontent.com/apache/parquet-testing/master/data/fixed_length_decimal_legacy.parquet", - # ), - # Need Decimal Support in Daft - # ( - # "parquet-testing/data/int32_decimal.parquet", - # "https://raw.githubusercontent.com/apache/parquet-testing/master/data/int32_decimal.parquet", - # ), + ( + "parquet-testing/data/fixed_length_decimal.parquet", + "https://raw.githubusercontent.com/apache/parquet-testing/master/data/fixed_length_decimal.parquet", + ), + ( + "parquet-testing/data/fixed_length_decimal_legacy.parquet", + "https://raw.githubusercontent.com/apache/parquet-testing/master/data/fixed_length_decimal_legacy.parquet", + ), + ( + "parquet-testing/data/int32_decimal.parquet", + "https://raw.githubusercontent.com/apache/parquet-testing/master/data/int32_decimal.parquet", + ), ( "parquet-testing/data/int32_with_null_pages.parquet", "https://raw.githubusercontent.com/apache/parquet-testing/master/data/int32_with_null_pages.parquet", ), - # Need Decimal Support in Daft - # ( - # "parquet-testing/data/int64_decimal.parquet", - # "https://raw.githubusercontent.com/apache/parquet-testing/master/data/int64_decimal.parquet", - # ), + ( + "parquet-testing/data/int64_decimal.parquet", + "https://raw.githubusercontent.com/apache/parquet-testing/master/data/int64_decimal.parquet", + ), ( "parquet-testing/data/list_columns.parquet", "https://raw.githubusercontent.com/apache/parquet-testing/master/data/list_columns.parquet",