GH-394 Add Sentry integration #808
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rollczi
reviewed
Jul 1, 2024
| options.setBeforeSend((event, hint) -> { | ||
| Throwable throwable = event.getThrowable(); | ||
|
|
||
| if (throwable != null) { |
There was a problem hiding this comment.
Co proponujesz, zwykłe pętle for()?
There was a problem hiding this comment.
Jakieś hashmapy sety coś takiego...
...core/src/main/java/com/eternalcode/core/bridge/sentry/SentryLiteCommandExceptionHandler.java
Show resolved
Hide resolved
| @@ -45,6 +46,7 @@ public static List<Class<?>> scanClasses(String packageToScan, ClassLoader class | |||
| return loadedClasses; | |||
| } | |||
| catch (IOException | ClassNotFoundException exception) { | |||
| Sentry.captureException(exception); | |||
There was a problem hiding this comment.
Trochę łopatologiczne Lucky jakoś globalnie kiedyś łapał błędy ale nw czy to tylko na wątki działa
There was a problem hiding this comment.
Ale łopatologiczne jest używanie wszędzie Sentry#captureException, czy co masz na myśli? Musimy tak robić bo ja nie łapię wszystkich błędów celowo, np. tych argumentów z LC, bo przecież tam to jest wina stricte usera
There was a problem hiding this comment.
Wątek w Javie ma coś takiego jak uncatched handler tyle, że musi wywalić wątek aby to złapało to część case już ogarnie... warto pomyśleć nad tym
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #394