Add new script to easily add the essential loader #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caoimhebyrne
requested changes
Dec 27, 2022
Johni0702
requested changes
Jan 13, 2023
Sychic
force-pushed
the
new/essential-loader-script
branch
from
2094ee0
to
c007fd0
Compare
Johni0702
requested changes
Feb 1, 2023
Sychic
force-pushed
the
new/essential-loader-script
branch
2 times, most recently
from
995d5db
to
f3de879
Compare
Sychic
force-pushed
the
new/essential-loader-script
branch
from
60b8a4f
to
5163d93
Compare
| when { | ||
| platform.isLegacyForge -> { | ||
| dependencies { | ||
| "implementation"(essentialLoader("gg.essential:loader-launchwrapper:1.2.2")!!) |
There was a problem hiding this comment.
Should there be a property for the loader version which just defaults to 1.2.2? (and we can change that whenever we get around to it)
Without one, we would have to make sure we always update this (which shouldn't be too often from my knowledge, but still)
There was a problem hiding this comment.
Maybe however the original intent was for the dev to have to do as little as possible (and I think it's mostly fine that the version is hardcoded since in theory the stage0 version should almost never change)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.