Fix animation strategies IN_EXPO and OUT_EXPO. #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johni0702
requested changes
Nov 14, 2023
There was a problem hiding this comment.
Does this not affect IN_OUT_EXP too?
Could probably just implement that in terms of IN_EXP and OUT_EXP instead of having an exact duplicate of their math in there. (well, almost exact duplicate: + 1 + 1 has been simplified to + 2)
Also, any reason to not use <= (or >=) instead of ==? Seems odd to have a discontinuous jump at 0 (or 1) but then go back to a small non-zero value immediately after. Granted, you're probably not supposed to pass values outside the range, but it's trivial to allow and gives reasonable values, so may as well.
|
Ah yeah, it does affect IN_OUT_EXP too. I'll remove the duplicate code. No specific reasoning behind ==, I just followed the examples directly. |
… when inputting values out of their bounds
Johni0702
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strategies didn't completely follow the provided code from https://easings.net/en and would return, for example with OUT_EXPO, 0.999 when percentComplete would be 1.0.