ScrollComponent: Implement better specification of direction #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should retain the original behavior where it defaults to preferring vertical when both are enabled.
|
For a bit of accounability/transparency: This PR is currently waiting on a fix for nested scrollers. |
This version changes the behavior of scroll components to not require holding shift if horizontal scrolling is the only option
…when we can no longer scroll in that direction
Johni0702
requested changes
Oct 13, 2023
src/main/kotlin/gg/essential/elementa/components/ScrollComponent.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/gg/essential/elementa/components/ScrollComponent.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/gg/essential/elementa/components/ScrollComponent.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/gg/essential/elementa/components/ScrollComponent.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/gg/essential/elementa/components/ScrollComponent.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/gg/essential/elementa/components/ScrollComponent.kt
Outdated
Show resolved
Hide resolved
|
Everything should be addressed in the last 5 commits |
Johni0702
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should retain the original behavior where it defaults to preferring vertical when both are enabled. This also allows for not requiring holding shift when horizontal is the only scroll direction.
Closes #123