Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify units of time throughout the project #24

Open
mattco98 opened this issue Jan 14, 2021 · 2 comments
Open

Unify units of time throughout the project #24

mattco98 opened this issue Jan 14, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@mattco98
Copy link
Contributor

Elementa uses multiple units of time in various APIs, when it should really only ever use one. We need to choose between using floats for number of seconds, or Longs for number of milliseconds. This has to be resolved before release of 2.0, as it would be a breaking change.

@mattco98 mattco98 added the enhancement New feature or request label Jan 14, 2021
@FalseHonesty
Copy link
Contributor

What uses millis? I have always intended to use seconds throughout the project, and thought I stuck to that?

@mattco98
Copy link
Contributor Author

I used milliseconds in the timer API because it mirrors every other API that deals with timers (Kotlin timers, JS's setInterval/setTimeout, etc). I can change it to float for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants