From 675720e6fbbd4330d8239ef26d7910837e5c5489 Mon Sep 17 00:00:00 2001 From: Prathamesh Narkhede <55591622+prathameshnarkhede@users.noreply.github.com> Date: Fri, 20 Sep 2024 10:22:45 -0700 Subject: [PATCH] Fixing Symbol Display sample (#606) * Switch cancelButton image to FontImageSource allowing for more flexible and scalable icon usage (#593) * Switch cancelButton image to FontImageSource allowing for more flexible and scalable icon usage with support for Dark/Light mode fixes. * Update cancelButton icon color to #6E6E6E Removed unused resources. * Add platform-specific min size for SymbolDisplay on Android to fix issue with Pixel 4 rendering. * Reverting changing height and width and removing Border to resolve the issue * Fixing SymbolDisplay on Android Pixel 4 device by removing Border element --- .../Samples/SymbolDisplaySample.xaml.cs | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/src/Samples/Toolkit.SampleApp.Maui/Samples/SymbolDisplaySample.xaml.cs b/src/Samples/Toolkit.SampleApp.Maui/Samples/SymbolDisplaySample.xaml.cs index f988eab08..d0bd7c66e 100644 --- a/src/Samples/Toolkit.SampleApp.Maui/Samples/SymbolDisplaySample.xaml.cs +++ b/src/Samples/Toolkit.SampleApp.Maui/Samples/SymbolDisplaySample.xaml.cs @@ -38,23 +38,14 @@ private void AddSymbol(Symbol symbol) { int columnCount = LayoutRoot.ColumnDefinitions.Count; var sd = new SymbolDisplay() { Symbol = symbol }; - Border border = new Border() - { - HorizontalOptions = LayoutOptions.Center, - VerticalOptions = LayoutOptions.Center, - Padding = 0, - StrokeThickness = 1, - }; - border.SetAppThemeColor(Microsoft.Maui.Controls.Border.StrokeProperty, Colors.Black, Colors.White); - border.Content = sd; int count = LayoutRoot.Children.Count; var row = count / columnCount; var column = count % columnCount; if (column == 0) LayoutRoot.RowDefinitions.Add(new RowDefinition()); - Grid.SetRow(border, row); - Grid.SetColumn(border, column); - LayoutRoot.Children.Add(border); + Grid.SetRow(sd, row); + Grid.SetColumn(sd, column); + LayoutRoot.Children.Add(sd); } } } \ No newline at end of file