Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus metrics for sync-status #636

Open
jbearer opened this issue Jun 10, 2024 · 0 comments
Open

Prometheus metrics for sync-status #636

jbearer opened this issue Jun 10, 2024 · 0 comments

Comments

@jbearer
Copy link
Member

jbearer commented Jun 10, 2024

Feature request from P2P: include the information from /node/sync-status in prometheus metrics. The challenge here is that prometheus metrics are inherently push-based: whenever a metric changes, some task is responsible for updating the registry. Whereas the way /node/sync-status currently works is pull-based: we only run it when queried, and it's quite expensive to run.

To make this work, we might need to develop an incremental way of tabulating this metric, so we can update Prometheus whenever it changes. We can then potentially use this incremental method to make the sync-status endpoint itself more efficient, although it should still do a full db scan at some frequency, so we catch things like corrupted or missing data, e.g. due to an RDS failover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant