Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STABILITY - Cancel Timeout Tasks properly #2165

Closed
2 tasks
bfish713 opened this issue Dec 5, 2023 · 0 comments · Fixed by #2204
Closed
2 tasks

STABILITY - Cancel Timeout Tasks properly #2165

bfish713 opened this issue Dec 5, 2023 · 0 comments · Fixed by #2204
Assignees
Labels

Comments

@bfish713
Copy link
Collaborator

bfish713 commented Dec 5, 2023

What is this task and why do we need to work on it?

When trying to improve our testing I realized that we don't ever emit anything when a view times out. This prevents us from failing due to to many views timing out. Because of this our test parameter for number of failures isn't doing very much. The only way to fix this is to properly emit a timeout external event. We can't do this because our timeout tasks don't get canceled properly so we end up with extra timeout events.

What work will need to be done to complete this task?

  • Complete the task whenever we get a view change which invalidates it, or it hits the time threshold
  • Emit a timeout event externally when the time threshold of the task is hit

Are there any other details to include?

No response

What are the acceptance criteria to close this issue?

  • All tests pass
  • I can observe through logging that the test task is receiving the ViewTimeout events

Branch work will be merged to (if not the default branch)

No response

@bfish713 bfish713 self-assigned this Dec 5, 2023
@bfish713 bfish713 changed the title STABILITY - Create a Proper Timeout Task STABILITY -Cancel Timeout Tasks properly Dec 12, 2023
@bfish713 bfish713 linked a pull request Dec 12, 2023 that will close this issue
@bfish713 bfish713 changed the title STABILITY -Cancel Timeout Tasks properly STABILITY - Cancel Timeout Tasks properly Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant