Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reassign event listener when onPlaceSelected changes #234

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Reassign event listener when onPlaceSelected changes #234

wants to merge 2 commits into from

Conversation

AleksandrZhukov
Copy link

I found that when onPlaceSelected handler has some dependencies, which can be change through the time - usePlacesWidget still calls the old version of onPlaceSelected.

Reassigning the event listener helps resolve this issue.

@AleksandrZhukov
Copy link
Author

@ErrorPro can it be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yograni2298 yograni2298 yograni2298 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AleksandrZhukov @yograni2298