Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Trinkets #5

Open
EnnuiL opened this issue Jun 24, 2024 · 1 comment
Open

Support Trinkets #5

EnnuiL opened this issue Jun 24, 2024 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@EnnuiL
Copy link
Owner

EnnuiL commented Jun 24, 2024

Trinkets! A library so well maintained that there are only PRs going on! The Italian translation is on the root folder of the goddamn thing! And yet your mod is the baddie here for breaking everything that messes with inventories! oh no that's actually bad

Currently, Trinkets does not like Ennui's Big Invs' extra slots at all, and it manifests most obviously on the creative inventory (like any other mod that attempts to expand the inventory!); Thankfully, you have a gambiarra meant to hackily inject support into such big-inv-no-likey mods, and with MixinSquared? you could do everything needed for Trinkets to work

@EnnuiL EnnuiL added bug Something isn't working enhancement New feature or request labels Jun 24, 2024
@EnnuiL
Copy link
Owner Author

EnnuiL commented Oct 8, 2024

An experimental prototype has been made on this by forking Trinkets, and well? it's going to be so tricky that really, i kinda hope something happens so i don't have to support trinkets aaaaaaaaaaaa
A Minecraft survival inventory, expanded into a 10x4 one by Ennui's Bigger Inventories, featuring Trinkets
A Minecraft creative inventory, expanded into a 10x4 one by Ennui's Bigger Inventories, featuring Trinkets
The visual glitches are mostly gone, but the more serious ones, that are the logic bugs, are still present; Compatibility is going to be super tricky and will require mixing into the Trinkets mixins, creating an alternative slot ID to be used on EBI worlds, as well as making sure there are no logic bugs at all between the off and on states, because the presence of any can be quite destructive!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant