Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift Crafting Item Deletion #5388

Open
Barchtic opened this issue May 8, 2023 · 8 comments
Open

Shift Crafting Item Deletion #5388

Barchtic opened this issue May 8, 2023 · 8 comments
Labels

Comments

@Barchtic
Copy link

Barchtic commented May 8, 2023

Modpack Version

1.8.0

Describe your issue.

Excess items will be deleted when shift crafting an item with a full inventory in any crafting inventory (crafting station, crafting table, 4x4 inventory grid).
This occurs only when you craft slightly more than a full stack worth of items. Eg. you have one open inventory slot and craft 8 items. You have two slots and craft 15 items.
Crafting any more than these quantities will prevent the shift craft but still delete the eighth ingot. (Crafting 9 ingots into one open inventory slot leaves one ingot in the crafting table and deletes the excess nuggets).

This behavior seems to only apply when items are shift crafted into quantities of 9. Such as ingots to nuggets, diamond blocks to diamonds etc. I tried with some blocks that convert into 4 items and it does not allow the craft.

Replicating:
Fill an inventory leaving a single slot open for the craft and place 8 items into a crafting grid that will output quantities of higher orders. (Eg. iron ingots to nuggets, redstone blocks to Redstone). Shift craft the items and you should see a full stack and the excess items (72-64=8) will be deleted.

Before:
https://i.imgur.com/stsFxBG.jpeg

After:
https://i.imgur.com/vKM5qJU.jpeg

Crash Report

No response

Latest Log

No response

Have you modified the modpack?

No

User Modifications

No response

Did the issue happen in singleplayer or on a server?

Both

Discord Username

Barchtic#0666

@Barchtic Barchtic added the Bug label May 8, 2023
@Barchtic
Copy link
Author

Barchtic commented May 8, 2023

Forgot to mention, typical behavior would be dropping the excess items on the ground.

@NielsPilgaard
Copy link
Collaborator

Thank you for the report, we will investigate the issue.

@Shadows-of-Fire
Copy link

I wonder if that's my fault, but such an issue undiscovered as far back as 1.16 would be unusual

@NielsPilgaard
Copy link
Collaborator

I was able to reproduce the issue by following the steps provided, so I think you may be at fault here @Shadows-of-Fire 😄

@Shadows-of-Fire
Copy link

Does it repro when fastworkbench is removed?

@NielsPilgaard
Copy link
Collaborator

Launching to test now :)

@Shadows-of-Fire
Copy link

What keeps me skeptical is it happens in the tcon table, which I don't modify.

However, they might be using a copy of my logic, which would have the same problem

@NielsPilgaard
Copy link
Collaborator

NielsPilgaard commented May 9, 2023

Ah damn, it's reproducible without FastWorkbench 😄

Perhaps it's an inventory tweaks / mouse tweaks kinda issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants