Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SideEffectSet inconsistencies, improve perf #2620

Merged
merged 2 commits into from
Sep 7, 2024
Merged

Fix SideEffectSet inconsistencies, improve perf #2620

merged 2 commits into from
Sep 7, 2024
+149 −22

Commits on Sep 7, 2024

  1. Fix SideEffectSet inconsistencies, improve perf 

    The `apply` term was inconsistent in this API, but should have always
been the same. This makes the "set" actually store the state of the
given effect, even if it's the default, and therefore consistent.
    @octylFractal
    octylFractal committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    3ecae68 View commit details
    Browse the repository at this point in the history

  2. Add property-based testing for SideEffectSet

    @octylFractal
    octylFractal committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    226fd67 View commit details
    Browse the repository at this point in the history