Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrieve BlockEntities tag in v3 Sponge Schematics optionally #2616

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Retrieve BlockEntities tag in v3 Sponge Schematics optionally #2616

merged 1 commit into from
Aug 31, 2024

Conversation

PierreSchwang
Copy link
Contributor

LinCompoundTag#findListTag does not throw an exception if the tag does not exists, but rather returns null. ReaderUtil.initializeClipboardFromBlocks already handles null for blockEntities - so passing null is safe.

Fixes #2615

@PierreSchwang PierreSchwang requested a review from a team as a code owner August 31, 2024 16:19
@octylFractal octylFractal enabled auto-merge (rebase) August 31, 2024 16:30
@octylFractal octylFractal merged commit cfd9eea into EngineHub:version/7.3.x Aug 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wizjany wizjany wizjany approved these changes

@octylFractal octylFractal octylFractal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sponge Schematic 3 Reader requires BlockEntites tag under Blocks
3 participants
@PierreSchwang @wizjany @octylFractal