Use DFU for updating MCEdit schematics #2373
Conversation
Brokkonaut
force-pushed
the
dfu-for-mcedit-schematics
branch
from
5e92020
to
b4695d3
Compare
|
How heavily has this been tested? I'd inclined to merge this if it does appear to work better, although would ideally prefer to try testing whatever issues led to them being skipped in the first place (if @wizjany remembers what they were) |
|
I think some of the issues were due to running the legacy fixers (i.e. from DV=-1) as opposed to using our inbuilt compathandlers in tandem with DFU from DV=1.13, as this PR does. That said DFU has always been finicky and it may be worth doing some error handling and throwing out tags that cause exceptions just in case? |
|
We could also add DFU as a side effect that can be turned off in //perf as a follow up too, if there are some instances where it's problematic to have it enabled |
|
Closed in 3923935, thanks - I ended up rebasing this against master rather than putting it into 7.2.x due to potential risk of the change. |
See #2370