Add a BiomeCategories API #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
me4502
force-pushed
the
feature/biome-categories
branch
from
c0935a8
to
8402d05
Compare
…system, but still retaining the inversion of control that this PR was intended to provide
octylFractal
approved these changes
Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds BiomeCategories, and reworks the category registry system to make it provided by the platform rather than pulling from the platform. Expanding this would heavily cleanup the code.
There are some open design questions though, the main ones being:
This PR mostly uses the new category type as a demo for the API changes; will follow up with entity categories too after this is all sorted
Fixes #2331