Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with GH pages #82

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Fix compatibility with GH pages #82

merged 1 commit into from
Aug 15, 2023

Conversation

WarningImHack3r
Copy link
Member

Fix/improve compatibility between SvelteKit and GitHub Pages, especially for error pages (with +error.svelte) that are not currently working. This works by removing any "GitHub magic sauce" by adding a .nojekyll file.

It could've been done by directly adding this empty file in the /static folder, however doing it through CI allows us to keep a platform-independent codebase and not get it polluted by yet another dot-file.

Both solutions come from the official docs for the adapter-static we're using.

Copy link
Contributor

@MinixBF MinixBF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top 👍🏻

@MinixBF MinixBF merged commit 08f10c0 into main Aug 15, 2023
6 checks passed
@MinixBF MinixBF deleted the sveltekit-gh-pages branch August 15, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants