Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git Hooks & .env #20

Merged
merged 22 commits into from
Aug 1, 2023
Merged

Git Hooks & .env #20

merged 22 commits into from
Aug 1, 2023

Conversation

WarningImHack3r
Copy link
Member

@WarningImHack3r WarningImHack3r commented Jun 22, 2023 •
edited
Loading

Warning
This PR needs to be merged after #18 because of the new URL in $config!

Changes

  • Use Git Hooks (through Husky) to automatically install dependencies on branch checkout
  • Move .env to $config for (TS and) version control support
  • Additionally rename $ts to $utils

Additional changes

  • Fix outdated inlang-plugin-json removing the last empty line of every "language JSON" at ./src/locales/{language}/*.json
  • Rework CI:
    • Name all CI jobs

      Warning
      Now that the jobs have a different name, the required workflow needs to be updated from Settings before being able to merge

    • Move auto-fixing tasks to a separate job
    • Move permissions to the job they are needed in
    • Fix the job not being able to run in forks or external contributions due to prohibited access to secrets

      Note
      Restart the PRs jobs once this is merged

    • Remove the now useless .env populating step

      Note
      Don't forget to delete the env secret once this is merged

    • Fix syntax
    • Remove a leftover useless comment
  • Update Dependabot
    • Add support for GitHub Actions update
    • Remove definitely useless target-branch option

@WarningImHack3r WarningImHack3r added the enhancement New feature or request label Jun 22, 2023
@WarningImHack3r WarningImHack3r removed the enhancement New feature or request label Jun 22, 2023
@WarningImHack3r WarningImHack3r marked this pull request as draft July 8, 2023 19:45
WarningImHack3r and others added 6 commits August 1, 2023 17:29
@WarningImHack3r
Merge branch 'main' into git-hooks-env
6e04255
@WarningImHack3r
Hopefully fix CI (again)
0ea9140 
- Move concurrency to the 'deploy' job to avoid cancelled jobs
- Add initial job that (should) return error when no access to secrets
- Use the right token accordingly
- Use 'ci' instead of 'i' for (p)npm
- Rename ci: tasks in package.json to avoid conflict
@WarningImHack3r
Revert pnpm ci changes, fix repo name
e7eab49
@WarningImHack3r
Fix pnpm i and access check
edd6355
@WarningImHack3r @github-actions
Fix lint
ae76273
@WarningImHack3r
Fix repo name
7c2375d
@WarningImHack3r WarningImHack3r marked this pull request as ready for review August 1, 2023 17:00
@WarningImHack3r WarningImHack3r merged commit b33927a into main Aug 1, 2023
5 checks passed
@WarningImHack3r WarningImHack3r deleted the git-hooks-env branch August 1, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinixBF MinixBF MinixBF approved these changes

Assignees

@WarningImHack3r WarningImHack3r

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WarningImHack3r @MinixBF