Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tsconfig.json #146

Merged
merged 3 commits into from
Oct 15, 2023
Merged

Update tsconfig.json #146

merged 3 commits into from
Oct 15, 2023

Conversation

WarningImHack3r
Copy link
Member

@WarningImHack3r WarningImHack3r commented Oct 11, 2023

Update the tsconfig.json following the video of Matt Pocock.

New additions

  • "moduleDetection": "force": Every file is treated as a module instead of a global script (is it good for the scripts/ folder?)
  • "noEmit": true: Ensures that no JS file will be produced during type-check
  • "verbatimModuleSyntax": true: Ensures the use of the correct cjs/mjs inside modules

Warning

I'm not sure all these additions are suited for the project/Svelte(Kit)/do not already exist in the base .svelte-kit/tsconfig.json, so it's not 100% safe to merge before a double check.


Note

PR 90% made from the GitHub Mobile app! Would've been 100% if we had the option to rename the branch we are creating :)

Copy link
Contributor

@MinixBF MinixBF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think everything's fine after checking on dev and seeing the video.

@WarningImHack3r
Copy link
Member Author

.svelte-kit/tsconfig.json doesn't contain any of these so I'm also good for merging that if you are!

@WarningImHack3r WarningImHack3r merged commit 59723ca into main Oct 15, 2023
5 checks passed
@WarningImHack3r WarningImHack3r deleted the tsconfig-update branch October 15, 2023 17:11
@MinixBF
Copy link
Contributor

MinixBF commented Oct 15, 2023

.svelte-kit/tsconfig.json doesn't contain any of these so I'm also good for merging that if you are!

I trust you on this. So let's go 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants