Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/typings readme #737

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

amittkSharma
Copy link

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you are merging your commits to master branch.
  • [x ] Add some descriptions and refer relative issues for you PR.
  • [x ] Rebase your commits to make your pull request meaningful.
  • [x ] Make sure that your changes pass npm test, npm run lint and npm run build.

Changes in this pull request

  • Typings and readme files of all most all components are fixed. In order to improve documentation and also enhancing development effort

@sam019 sam019 requested a review from e1emeb0t March 19, 2018 07:12
Copy link
Contributor

@e1emeb0t e1emeb0t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your work is so graceful, special thanks and sorry for the delay. LGTM.

@e1emeb0t e1emeb0t added the <3 label Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants