Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbar: Fixed infinite execution of the scrollbar component componentDidUpdate hook function #1035

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rookie125
Copy link

@rookie125 rookie125 commented Nov 28, 2019

…Update hook function

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you are merging your commits to master branch.
  • Add some descriptions and refer relative issues for you PR.
  • Rebase your commits to make your pull request meaningful.
  • Make sure that your changes pass npm test, npm run lint and npm run build.

Changes in this pull request

  • 修复了滚动条componentDidUpdate钩子函数的无限执行问题

@jdsandifer
Copy link

@rookie125 It's been a while since you started this PR - are you still interested in working on this? It looks like the branch needs to be updated and an ESLint error needs to be fixed before this can be merged (it says there's a dependency loop).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants