Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set no backup for all URLs that Initializer uses #1370

Open
LukasKorba opened this issue Feb 5, 2024 · 1 comment
Open

Set no backup for all URLs that Initializer uses #1370

LukasKorba opened this issue Feb 5, 2024 · 1 comment

Comments

@LukasKorba
Copy link
Collaborator

All there URLs currently allow backing up to the iCloud (+ all other direct solutions like 2 iPhones close to each other).

    struct URLs {
        let fsBlockDbRoot: URL
        let dataDbURL: URL
        let generalStorageURL: URL
        let spendParamsURL: URL
        let outputParamsURL: URL
    }

When a user buys a new iPhone and restores from the backup, Zashi is restored with all files and folders in these URLs but keys (recovery phrase, birthday) are missing. This is unwanted and we should no backup anything in these URLs.

Use https://developer.apple.com/documentation/foundation/urlresourcevalues

@pacu
Copy link
Contributor

pacu commented Feb 5, 2024

I'm just going through this. I believe that side-by-side phone transfers should be allowed. It is the user intent (in this case myself, but could be any other) that the phone is a "clone" of the other one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants