Add "Go to Parent Wallet" wallet menu option #5301
Merged
+24
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
requested changes
Oct 10, 2024
| navigation.navigate('transactionList', { | ||
| walletId, | ||
| tokenId: null, | ||
| walletName: wallet.name ?? wallet.currencyInfo.displayName |
There was a problem hiding this comment.
Never access wallet.name directly. We have a helper function for this, getWalletName, that handles all the fallback stuff.
Jon-edge
force-pushed
the
jon/parent-wallet-option
branch
from
c760162
to
eeed0ba
Compare
swansontec
approved these changes
Oct 11, 2024
Jon-edge
force-pushed
the
jon/parent-wallet-option
branch
from
f5e25d8
to
2e7b732
Compare
Jon-edge
force-pushed
the
jon/parent-wallet-option
branch
from
2e7b732
to
1cbca71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: