Skip to content
This repository has been archived by the owner on Oct 13, 2021. It is now read-only.

Migrate Ads to Eclipse Newsroom #258

Open
ericpoirier opened this issue Nov 13, 2020 · 2 comments
Open

Migrate Ads to Eclipse Newsroom #258

ericpoirier opened this issue Nov 13, 2020 · 2 comments
Assignees

Comments

@ericpoirier
Copy link
Contributor

For now I still need to finalize the changes in the Newsroom website (create content type and create endpoint).

I think we might want to add the List All Ads page to Newsroom. We could create a Views that lists all ads and create a redirect from the original page on eclipse.org to the page that will be created on Newsroom.

Once I am done with this, we will need to do the same thing has what has been done in Issue EclipseFdn/jquery-eclipsefdn-api#14 .

@ericpoirier ericpoirier self-assigned this Nov 13, 2020
@ericpoirier
Copy link
Contributor Author

@autumnfound, Here is a zipped json file containing the output of 3 ads that I added locally to the Newsroom website.

ads.json.zip

Let me know if there is something missing or if you have any questions.

@autumnfound
Copy link
Contributor

So far, using a modified version of the JSON provided, I've finished the following features:

  • Random ads using weighting
  • All ads display that copies whats available on eclipse.org
  • possibility to override ad template

Currently missing in implementation:

  • pagination support
  • strategic vs paid filter
  • publish target support
  • specific ad retrieval by index

Feedback on endpoint:
I don't think that the pagination link header model is appropriate here. When we retrieve ads, we don't want to retrieve some of them as with weighting, we need all available always. This adds a barrier and extra steps to writing with no tangible benefit.

@chrisguindon chrisguindon transferred this issue from EclipseFdn/jquery-eclipsefdn-api Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants