You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 13, 2021. It is now read-only.
For now I still need to finalize the changes in the Newsroom website (create content type and create endpoint).
I think we might want to add the List All Ads page to Newsroom. We could create a Views that lists all ads and create a redirect from the original page on eclipse.org to the page that will be created on Newsroom.
So far, using a modified version of the JSON provided, I've finished the following features:
Random ads using weighting
All ads display that copies whats available on eclipse.org
possibility to override ad template
Currently missing in implementation:
pagination support
strategic vs paid filter
publish target support
specific ad retrieval by index
Feedback on endpoint:
I don't think that the pagination link header model is appropriate here. When we retrieve ads, we don't want to retrieve some of them as with weighting, we need all available always. This adds a barrier and extra steps to writing with no tangible benefit.
For now I still need to finalize the changes in the Newsroom website (create content type and create endpoint).
I think we might want to add the List All Ads page to Newsroom. We could create a Views that lists all ads and create a redirect from the original page on eclipse.org to the page that will be created on Newsroom.
Once I am done with this, we will need to do the same thing has what has been done in Issue EclipseFdn/jquery-eclipsefdn-api#14 .
The text was updated successfully, but these errors were encountered: