Skip to content
This repository has been archived by the owner on Oct 13, 2021. It is now read-only.

Footer and main content missing space #185

Open
flora8984461 opened this issue Oct 29, 2020 · 7 comments
Open

Footer and main content missing space #185

flora8984461 opened this issue Oct 29, 2020 · 7 comments
Assignees

Comments

@flora8984461
Copy link
Contributor

flora8984461 commented Oct 29, 2020

This can cause something like: https://projects.eclipse.org/projects/ecd

image

@flora8984461
Copy link
Contributor Author

flora8984461 commented Oct 29, 2020

But need to be careful with this, since on Hugo sites, there are some styles have margin-top for footer, and I think we cannot directly add spacing to featured_footer since we have some custom_footer need to be directly connected with featured_footer.

@chrisguindon
Copy link
Member

I don't think the problem is with the footer. I would expect the .div containing the charts to have a martin-bottom.

I think we want to avoid adding a margin-top to the featured footer because we don't always need it.

For example,
https://sparkplug.eclipse.org/

@flora8984461
Copy link
Contributor Author

I don't think the problem is with the footer. I would expect the .div containing the charts to have a martin-bottom.

I think we want to avoid adding a margin-top to the featured footer because we don't always need it.

For example,
https://sparkplug.eclipse.org/

Yeah, I think the region region-content solstice-region-element-count-1 or the maint-content-area probably need a margin-bottom at this type of page. But I think we probably add a specific new class name to these pages so that it won't affect others with the same id or class name. 🤔

@flora8984461
Copy link
Contributor Author

Can we add the existing class "margin-bottom-n" to this type of pages https://projects.eclipse.org/projects/[PROJECTNAME] ? 🤔

@chrisguindon
Copy link
Member

yes, that might be the solution!

@chrisguindon
Copy link
Member

I need to finish updating our drupal stack so that you can help us update our drupal sites :)

@ericpoirier
Copy link
Contributor

I created a patch for the Solstice drupal theme to add the margin-bottom-20 class.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants